You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/07/15 06:17:57 UTC

[GitHub] [incubator-ratis] GlenGeng edited a comment on pull request #144: RATIS-998: shouldWithholdVotes() should be triggered for handling higher term

GlenGeng edited a comment on pull request #144:
URL: https://github.com/apache/incubator-ratis/pull/144#issuecomment-658554119


   @szetszwo  Hello Nicholas, could you please have a quick look for this PR ?
   
   I consider that: 
   1) withhold vote should be used for higher term from disruptive server, 
   2) request vote can work correctly, but `shouldWithholdVotes` is redundant.
   
   Since the change is critical, could you please double confirm. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org