You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/29 14:09:44 UTC

[GitHub] [hudi] leesf commented on a change in pull request #3183: [HUDI-2090]when hudi metadata is enabled, use different users to quer…

leesf commented on a change in pull request #3183:
URL: https://github.com/apache/hudi/pull/3183#discussion_r660655900



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/DiskBasedMap.java
##########
@@ -111,8 +111,14 @@ private void initFile(File writeOnlyFile) throws IOException {
     if (writeOnlyFile.exists()) {
       writeOnlyFile.delete();
     }
-    if (!writeOnlyFile.getParentFile().exists()) {
-      writeOnlyFile.getParentFile().mkdir();
+    File parentDir = writeOnlyFile.getParentFile();
+    if (!parentDir.exists()) {
+      parentDir.mkdir();
+      // we should set all right for other user.

Review comment:
       `we should set all rights for all users, otherwise some users cannot access this directory and cause query to fail?` and is it possible to add unit test for this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org