[GitHub] [flink] yuzelin commented on a diff in pull request #20714: [FLINK-29118][sql-gateway] Remove 'default_catalog' in the HiveServer2 Endpoint

[GitBox <gi...@apache.org>]

yuzelin commented on code in PR #20714:
URL: https://github.com/apache/flink/pull/20714#discussion_r962452601


##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java:
##########
@@ -207,13 +208,13 @@ public void close() {
     public static SessionContext create(
             DefaultContext defaultContext,
             SessionHandle sessionId,
-            EndpointVersion endpointVersion,
-            Configuration sessionConf,
+            SessionEnvironment environment,
             ExecutorService operationExecutorService) {
         // --------------------------------------------------------------------------------------------------------------
         // Init config
         // --------------------------------------------------------------------------------------------------------------
 
+        Configuration sessionConf = Configuration.fromMap(environment.getSessionConfig());
         Configuration configuration = defaultContext.getFlinkConfig().clone();
         configuration.addAll(sessionConf);

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org