You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/08 09:20:18 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1340: Fix the minor style issue
xiaoxiang781216 opened a new pull request, #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340
## Summary
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991497751
##########
system/nxrecorder/nxrecorder.c:
##########
@@ -225,21 +225,21 @@ static int nxrecorder_enqueuebuffer(FAR struct nxrecorder_s *precorder,
static void *nxrecorder_recordthread(pthread_addr_t pvarg)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992661169
##########
examples/netloop/lo_listener.c:
##########
@@ -297,7 +297,7 @@ void *lo_listener(pthread_addr_t pvarg)
memset(&nls, 0, sizeof(struct net_listener_s));
if (!net_mksocket(&nls))
{
- return (void*)1;
+ return (void *)1;
Review Comment:
Please fix long line at line 88 as well
##########
examples/pipe/transfer_test.c:
##########
@@ -80,8 +79,7 @@ static void *transfer_reader(pthread_addr_t pvarg)
"transfer_reader: read failed, errno=%d\n", \
errno);
- p = (void *) 1;
- return p;
+ return (void *)1;
Review Comment:
ditto
##########
examples/pipe/transfer_test.c:
##########
@@ -160,21 +153,18 @@ static void *transfer_writer(pthread_addr_t pvarg)
{
fprintf(stderr, \
"transfer_writer: write failed, errno=%d\n", errno);
- p = (void *) 1;
- return p;
+ return (void *)1;
Review Comment:
ditto
##########
examples/pipe/transfer_test.c:
##########
@@ -204,26 +195,49 @@ int transfer_test(int fdin, int fdout)
fprintf(stderr, \
"transfer_test: Failed to create transfer_reader thread, \
error=%d\n", ret);
+=======
+ printf("transfer_test: Starting transfer_reader thread\n");
+ ret = pthread_create(&readerid, NULL,
+ transfer_reader, (pthread_addr_t)fdin);
+ if (ret != 0)
+ {
+ fprintf(stderr, "transfer_test: Failed to create transfer_reader"
+ " thread, error=%d\n", ret);
+>>>>>>> Fix the minor style issue
return 1;
}
/* Start transfer_writer thread */
printf("transfer_test: Starting transfer_writer thread\n");
+<<<<<<< HEAD
ret = pthread_create(&writerid, \
NULL, transfer_writer, (void *)(intptr_t)fdout);
if (ret != 0)
{
fprintf(stderr, \
"transfer_test: Failed to create transfer_writer thread, \
error=%d\n", ret);
+=======
+ ret = pthread_create(&writerid, NULL,
+ transfer_writer, (pthread_addr_t)fdout);
+ if (ret != 0)
+ {
+ fprintf(stderr, "transfer_test: Failed to create transfer_writer "
+ "thread, error=%d\n", ret);
+>>>>>>> Fix the minor style issue
pthread_detach(readerid);
ret = pthread_cancel(readerid);
if (ret != 0)
{
+<<<<<<< HEAD
fprintf(stderr, \
"transfer_test: Failed to cancel transfer_reader thread, \
error=%d\n", ret);
+=======
Review Comment:
ditto
##########
netutils/wakeonlan/wol_main.c:
##########
@@ -66,7 +66,7 @@ static int send_wol(FAR struct ether_addr *dest,
}
ret = setsockopt(sockfd, SOL_SOCKET, SO_BROADCAST,
- (void *)&optval, sizeof(optval));
+ &optval, sizeof(optval));
Review Comment:
```suggestion
&optval, sizeof(optval));
```
##########
netutils/pppd/ipcp.c:
##########
@@ -87,7 +87,7 @@ static const uint8_t g_ipcplist[] =
#if PPP_DEBUG
void printip(struct in_addr ip2)
{
- char *ip = (FAR uint8_t *) & ip2.s_addr;
+ char *ip = (FAR uint8_t *)&ip2.s_addr;
Review Comment:
quite a strange cast
##########
examples/pipe/transfer_test.c:
##########
@@ -91,8 +89,7 @@ static void *transfer_reader(pthread_addr_t pvarg)
"transfer_reader: Too few bytes read -- aborting: %d\n", \
nbytes);
- p = (void *) 2;
- return p;
+ return (void *)2;
Review Comment:
ditto
##########
examples/poll/net_listener.c:
##########
@@ -343,7 +343,7 @@ void *net_listener(pthread_addr_t pvarg)
memset(&nls, 0, sizeof(struct net_listener_s));
if (!net_mksocket(&nls))
{
- return (void*)1;
+ return (void *)1;
Review Comment:
ditto
##########
examples/pipe/transfer_test.c:
##########
@@ -124,15 +120,13 @@ static void *transfer_reader(pthread_addr_t pvarg)
"transfer_reader: Too many bytes read -- aborting: %d\n", \
nbytes);
- p = (void *) 4;
- return p;
+ return (void *)4;
Review Comment:
ditto
##########
examples/pipe/interlock_test.c:
##########
@@ -73,8 +72,7 @@ static void *null_writer(pthread_addr_t pvarg)
fprintf(stderr, \
"null_writer: Failed to open FIFO %s for writing, errno=%d\n",
FIFO_PATH2, errno);
- p = (void *) 1;
- return p;
+ return (void *)1;
Review Comment:
seems to be a revert of recently merged change. Maybe we need additional cast to `uintptr_t`?
##########
examples/pipe/transfer_test.c:
##########
@@ -160,21 +153,18 @@ static void *transfer_writer(pthread_addr_t pvarg)
{
fprintf(stderr, \
"transfer_writer: write failed, errno=%d\n", errno);
- p = (void *) 1;
- return p;
+ return (void *)1;
}
else if (ret != WRITE_SIZE)
{
fprintf(stderr, \
"transfer_writer: Unexpected write size=%d\n", ret);
- p = (void *) 2;
- return p;
+ return (void *)2;
Review Comment:
ditto
##########
examples/pipe/transfer_test.c:
##########
@@ -110,8 +107,7 @@ static void *transfer_reader(pthread_addr_t pvarg)
"transfer_reader: Byte %d, expected %d, found %d\n",
nbytes + ndx, value, buffer[ndx]);
- p = (void *) 3;
- return p;
+ return (void *)3;
Review Comment:
ditto
##########
examples/pipe/transfer_test.c:
##########
@@ -204,26 +195,49 @@ int transfer_test(int fdin, int fdout)
fprintf(stderr, \
"transfer_test: Failed to create transfer_reader thread, \
error=%d\n", ret);
+=======
+ printf("transfer_test: Starting transfer_reader thread\n");
+ ret = pthread_create(&readerid, NULL,
+ transfer_reader, (pthread_addr_t)fdin);
+ if (ret != 0)
+ {
+ fprintf(stderr, "transfer_test: Failed to create transfer_reader"
+ " thread, error=%d\n", ret);
+>>>>>>> Fix the minor style issue
return 1;
}
/* Start transfer_writer thread */
printf("transfer_test: Starting transfer_writer thread\n");
+<<<<<<< HEAD
ret = pthread_create(&writerid, \
NULL, transfer_writer, (void *)(intptr_t)fdout);
if (ret != 0)
{
fprintf(stderr, \
"transfer_test: Failed to create transfer_writer thread, \
error=%d\n", ret);
+=======
Review Comment:
ditto
##########
examples/pipe/transfer_test.c:
##########
@@ -204,26 +195,49 @@ int transfer_test(int fdin, int fdout)
fprintf(stderr, \
"transfer_test: Failed to create transfer_reader thread, \
error=%d\n", ret);
+=======
Review Comment:
Please resolve merge conflict
##########
netutils/pppd/ipcp.c:
##########
@@ -346,10 +346,10 @@ void ipcp_rx(FAR struct ppp_context_s *ctx, FAR uint8_t * buffer,
bptr++;
- ((FAR uint8_t *) & ctx->local_ip)[0] = (char)*bptr++;
- ((FAR uint8_t *) & ctx->local_ip)[1] = (char)*bptr++;
- ((FAR uint8_t *) & ctx->local_ip)[2] = (char)*bptr++;
- ((FAR uint8_t *) & ctx->local_ip)[3] = (char)*bptr++;
+ ((FAR uint8_t *)&ctx->local_ip)[0] = (char)*bptr++;
+ ((FAR uint8_t *)&ctx->local_ip)[1] = (char)*bptr++;
+ ((FAR uint8_t *)&ctx->local_ip)[2] = (char)*bptr++;
+ ((FAR uint8_t *)&ctx->local_ip)[3] = (char)*bptr++;
netlib_ifup((char *)ctx->ifname);
netlib_set_ipv4addr((char *)ctx->ifname, &ctx->local_ip);
Review Comment:
```suggestion
netlib_ifup((FAR char *)ctx->ifname);
netlib_set_ipv4addr((FAR char *)ctx->ifname, &ctx->local_ip);
```
##########
platform/mikroe-stm32f4/mikroe_configdata.c:
##########
@@ -94,7 +94,7 @@ int platform_setconfig(enum config_data_e id, int instance,
config.id = (enum config_data_e)id;
config.instance = instance;
- config.configdata = (FAR uint8_t *) configdata;
+ config.configdata = (FAR uint8_t *)configdata;
config.len = datalen;
ret = ioctl(fd, CFGDIOC_SETCONFIG, (unsigned long) &config);
Review Comment:
```suggestion
ret = ioctl(fd, CFGDIOC_SETCONFIG, (unsigned long)&config);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991495975
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO avoid */
int rxoff; /* Current offset within RX buffer */
char tmpbuf[16]; /* Buffer to hold small strings */
int tmplen; /* Number of bytes used in tmpbuffer */
int state; /* Current state of the parser */
int ret; /* Return value from internal calls */
- char * headerbuf;
+ char *headerbuf;
int headerlen;
- char * end;
+ char *end;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992506078
##########
examples/pipe/transfer_test.c:
##########
@@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg)
int ndx;
printf("transfer_reader: started\n");
- for (nbytes = 0, value = 0; nbytes < NREAD_BYTES;)
+ for (nbytes = 0, value = 0; nbytes < NREAD_BYTES; )
{
ret = read(fd, buffer, READ_SIZE);
- if (ret < 0 )
+ if (ret < 0)
{
- fprintf(stderr, "transfer_reader: read failed, errno=%d\n", errno);
- return (void*)1;
+ fprintf(stderr,
+ "transfer_reader: read failed, errno=%d\n", errno);
+ return (void *)1;
}
else if (ret == 0)
{
if (nbytes < NREAD_BYTES)
{
- fprintf(stderr, "transfer_reader: Too few bytes read -- aborting: %d\n", nbytes);
- return (void*)2;
+ fprintf(stderr,
+ "transfer_reader: Too few bytes read -- aborting: %d\n",
+ nbytes);
+ return (void *)2;
}
break;
}
+
for (ndx = 0; ndx < ret; ndx++)
{
if (value >= WRITE_SIZE)
{
value = 0;
}
+
if (buffer[ndx] != value)
{
- fprintf(stderr, "transfer_reader: Byte %d, expected %d, found %d\n",
+ fprintf(stderr,
+ "transfer_reader: Byte %d, expected %d, found %d\n",
nbytes + ndx, value, buffer[ndx]);
- return (void*)3;
+ return (void *)3;
}
+
value++;
}
+
nbytes += ret;
if (nbytes > NREAD_BYTES)
{
- fprintf(stderr, "transfer_reader: Too many bytes read -- aborting: %d\n", nbytes);
- return (void*)4;
+ fprintf(stderr,
+ "transfer_reader: Too many bytes read -- aborting: %d\n",
+ nbytes);
+ return (void *)4;
}
}
+
printf("transfer_reader: %d bytes read\n", nbytes);
- return (void*)0;
+ return (void *)0;
Review Comment:
Donee.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991668033
##########
examples/pipe/transfer_test.c:
##########
@@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg)
int ndx;
printf("transfer_reader: started\n");
- for (nbytes = 0, value = 0; nbytes < NREAD_BYTES;)
+ for (nbytes = 0, value = 0; nbytes < NREAD_BYTES; )
{
ret = read(fd, buffer, READ_SIZE);
- if (ret < 0 )
+ if (ret < 0)
{
- fprintf(stderr, "transfer_reader: read failed, errno=%d\n", errno);
- return (void*)1;
+ fprintf(stderr,
+ "transfer_reader: read failed, errno=%d\n", errno);
+ return (void *)1;
}
else if (ret == 0)
{
if (nbytes < NREAD_BYTES)
{
- fprintf(stderr, "transfer_reader: Too few bytes read -- aborting: %d\n", nbytes);
- return (void*)2;
+ fprintf(stderr,
+ "transfer_reader: Too few bytes read -- aborting: %d\n",
+ nbytes);
+ return (void *)2;
}
break;
}
+
for (ndx = 0; ndx < ret; ndx++)
{
if (value >= WRITE_SIZE)
{
value = 0;
}
+
if (buffer[ndx] != value)
{
- fprintf(stderr, "transfer_reader: Byte %d, expected %d, found %d\n",
+ fprintf(stderr,
+ "transfer_reader: Byte %d, expected %d, found %d\n",
nbytes + ndx, value, buffer[ndx]);
- return (void*)3;
+ return (void *)3;
}
+
value++;
}
+
nbytes += ret;
if (nbytes > NREAD_BYTES)
{
- fprintf(stderr, "transfer_reader: Too many bytes read -- aborting: %d\n", nbytes);
- return (void*)4;
+ fprintf(stderr,
+ "transfer_reader: Too many bytes read -- aborting: %d\n",
+ nbytes);
+ return (void *)4;
}
}
+
printf("transfer_reader: %d bytes read\n", nbytes);
- return (void*)0;
+ return (void *)0;
Review Comment:
```suggestion
return NULL;
```
##########
examples/pipe/transfer_test.c:
##########
@@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg)
int ndx;
printf("transfer_reader: started\n");
- for (nbytes = 0, value = 0; nbytes < NREAD_BYTES;)
+ for (nbytes = 0, value = 0; nbytes < NREAD_BYTES; )
{
ret = read(fd, buffer, READ_SIZE);
- if (ret < 0 )
+ if (ret < 0)
{
- fprintf(stderr, "transfer_reader: read failed, errno=%d\n", errno);
- return (void*)1;
+ fprintf(stderr,
+ "transfer_reader: read failed, errno=%d\n", errno);
+ return (void *)1;
Review Comment:
Do we need FAR here?
##########
examples/pipe/interlock_test.c:
##########
@@ -69,9 +69,10 @@ static void *null_writer(pthread_addr_t pvarg)
fd = open(FIFO_PATH2, O_WRONLY);
if (fd < 0)
{
- fprintf(stderr, "null_writer: Failed to open FIFO %s for writing, errno=%d\n",
+ fprintf(stderr, "null_writer: "
+ "Failed to open FIFO %s for writing, errno=%d\n",
FIFO_PATH2, errno);
- return (void*)1;
+ return (void *)1;
Review Comment:
Do we need FAR here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992062166
##########
examples/pipe/transfer_test.c:
##########
@@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg)
int ndx;
printf("transfer_reader: started\n");
- for (nbytes = 0, value = 0; nbytes < NREAD_BYTES;)
+ for (nbytes = 0, value = 0; nbytes < NREAD_BYTES; )
{
ret = read(fd, buffer, READ_SIZE);
- if (ret < 0 )
+ if (ret < 0)
{
- fprintf(stderr, "transfer_reader: read failed, errno=%d\n", errno);
- return (void*)1;
+ fprintf(stderr,
+ "transfer_reader: read failed, errno=%d\n", errno);
+ return (void *)1;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991498774
##########
system/nxrecorder/nxrecorder.c:
##########
@@ -225,21 +225,21 @@ static int nxrecorder_enqueuebuffer(FAR struct nxrecorder_s *precorder,
static void *nxrecorder_recordthread(pthread_addr_t pvarg)
{
- struct nxrecorder_s *precorder = (struct nxrecorder_s *)pvarg;
- struct audio_msg_s msg;
- struct audio_buf_desc_s buf_desc;
- ssize_t size;
- bool running = true;
- bool streaming = true;
- bool failed = false;
- struct ap_buffer_info_s buf_info;
- FAR struct ap_buffer_s **pbuffers;
- unsigned int prio;
+ struct nxrecorder_s *precorder = (struct nxrecorder_s *)pvarg;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992130915
##########
wireless/ieee802154/libmac/sixlowpan_getreq.c:
##########
@@ -40,7 +40,7 @@
****************************************************************************/
int sixlowpan_get_req(int sock, FAR const char *ifname,
- FAR const struct ieee802154_get_req_s *req)
+ FAR struct ieee802154_get_req_s *req)
Review Comment:
why `const` is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992257807
##########
examples/elf/tests/mutex/mutex.c:
##########
@@ -103,7 +103,7 @@ int main(int argc, char **argv)
printf("Starting thread 1\n");
bendoftest = false;
- if ((pthread_create(&thread1, NULL, (void*)thread_func, (void*)1)) != 0)
+ if ((pthread_create(&thread1, NULL, (void *)thread_func, (void *)1)) != 0)
Review Comment:
Can we fix ling line warning at line 45?
##########
examples/apds9960/apds9960_main.c:
##########
@@ -64,7 +64,7 @@ int main(int argc, FAR char *argv[])
while (1)
{
- nbytes = read(fd, (void *)&gest, sizeof(gest));
+ nbytes = read(fd, &gest, sizeof(gest));
Review Comment:
@xiaoxiang781216 do you know why style check reports error at like 56?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#issuecomment-1279796998
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991501528
##########
examples/ustream/ustream_client.c:
##########
@@ -90,7 +90,7 @@ int main(int argc, FAR char *argv[])
printf("client: Connecting to %s...\n", CONFIG_EXAMPLES_USTREAM_ADDR);
addrlen += sizeof(sa_family_t) + 1;
- ret = connect( sockfd, (struct sockaddr *)&myaddr, addrlen);
+ ret = connect(sockfd, (struct sockaddr *)&myaddr, addrlen);
Review Comment:
since the whole ustream_client.c doesn't add FAR, let's do the clean up in the new PR instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991499578
##########
system/nxplayer/nxplayer.c:
##########
@@ -74,9 +74,9 @@
#ifdef CONFIG_NXPLAYER_FMT_FROM_EXT
struct nxplayer_ext_fmt_s
{
- const char *ext;
- uint16_t format;
- CODE int (*getsubformat)(int fd);
+ const char *ext;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r995766386
##########
examples/netloop/lo_listener.c:
##########
@@ -297,7 +299,7 @@ void *lo_listener(pthread_addr_t pvarg)
memset(&nls, 0, sizeof(struct net_listener_s));
if (!net_mksocket(&nls))
{
- return (void*)1;
+ return (void *)(uintptr_t)1;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992941872
##########
examples/poll/net_listener.c:
##########
@@ -343,7 +343,7 @@ void *net_listener(pthread_addr_t pvarg)
memset(&nls, 0, sizeof(struct net_listener_s));
if (!net_mksocket(&nls))
{
- return (void*)1;
+ return (void *)1;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#issuecomment-1279775369
@xiaoxiang781216 could you please take a look on CI failures? I restarted it couple of time, but failures persist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#issuecomment-1272275353
Please ignore the style warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992508355
##########
examples/elf/tests/mutex/mutex.c:
##########
@@ -103,7 +103,7 @@ int main(int argc, char **argv)
printf("Starting thread 1\n");
bendoftest = false;
- if ((pthread_create(&thread1, NULL, (void*)thread_func, (void*)1)) != 0)
+ if ((pthread_create(&thread1, NULL, (void *)thread_func, (void *)1)) != 0)
Review Comment:
Fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r995765730
##########
netutils/thttpd/cgi-src/ssi.c:
##########
@@ -99,81 +99,82 @@ static void internal_error(char *reason)
{
char *title = "500 Internal Error";
- printf("\
-<HTML><HEAD><TITLE>%s</TITLE></HEAD>\n\
-<BODY><H2>%s</H2>\n\
-Something unusual went wrong during a server-side-includes request:\n\
-<BLOCKQUOTE>\n\
-%s\n\
-</BLOCKQUOTE>\n\
-</BODY></HTML>\n", title, title, reason);
+ printf("<HTML><HEAD><TITLE>%s</TITLE></HEAD>\n"
+ "<BODY><H2>%s</H2>\n"
+ "Something unusual went wrong during a server-side-includes request:\n"
+ "<BLOCKQUOTE>\n"
+ "%s\n"
+ "</BLOCKQUOTE>\n"
+ "</BODY></HTML>\n",
+ title, title, reason);
Review Comment:
can't since the line 104 will exceed 79 chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#issuecomment-1274607182
Please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991499170
##########
system/nxplayer/nxplayer.c:
##########
@@ -752,21 +752,21 @@ static int nxplayer_enqueuebuffer(FAR struct nxplayer_s *pplayer,
static void *nxplayer_playthread(pthread_addr_t pvarg)
{
- struct nxplayer_s *pplayer = (struct nxplayer_s *)pvarg;
- struct audio_msg_s msg;
- struct audio_buf_desc_s buf_desc;
- ssize_t size;
- bool running = true;
- bool streaming = true;
- bool failed = false;
- struct ap_buffer_info_s buf_info;
- FAR struct ap_buffer_s **buffers;
- unsigned int prio;
+ struct nxplayer_s *pplayer = (struct nxplayer_s *)pvarg;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992229836
##########
wireless/ieee802154/libmac/sixlowpan_getreq.c:
##########
@@ -40,7 +40,7 @@
****************************************************************************/
int sixlowpan_get_req(int sock, FAR const char *ifname,
- FAR const struct ieee802154_get_req_s *req)
+ FAR struct ieee802154_get_req_s *req)
Review Comment:
since the function modify argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r990694889
##########
examples/ustream/ustream_client.c:
##########
@@ -90,7 +90,7 @@ int main(int argc, FAR char *argv[])
printf("client: Connecting to %s...\n", CONFIG_EXAMPLES_USTREAM_ADDR);
addrlen += sizeof(sa_family_t) + 1;
- ret = connect( sockfd, (struct sockaddr *)&myaddr, addrlen);
+ ret = connect(sockfd, (struct sockaddr *)&myaddr, addrlen);
Review Comment:
```suggestion
ret = connect(sockfd, (FAR struct sockaddr *)&myaddr, addrlen);
```
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO avoid */
Review Comment:
```suggestion
FAR FILE *stream; /* IOSTREAM used to printf in the socket TODO avoid */
```
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO avoid */
int rxoff; /* Current offset within RX buffer */
char tmpbuf[16]; /* Buffer to hold small strings */
int tmplen; /* Number of bytes used in tmpbuffer */
int state; /* Current state of the parser */
int ret; /* Return value from internal calls */
- char * headerbuf;
+ char *headerbuf;
Review Comment:
```suggestion
FAR char *headerbuf;
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -516,9 +516,9 @@ static inline int nxplayer_fmtfromextension(FAR struct nxplayer_s *pplayer,
FAR const char *pfilename,
FAR int *subfmt)
{
- const char *pext;
- uint8_t x;
- uint8_t c;
+ const char *pext;
Review Comment:
```suggestion
FAR const char *pext;
```
##########
netutils/usrsock_rpmsg/usrsock_rpmsg_client.c:
##########
@@ -262,7 +262,7 @@ int main(int argc, char *argv[])
while (1)
{
struct pollfd pfd;
- void *buf;
+ void *buf;
Review Comment:
```suggestion
FAR void *buf;
```
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO avoid */
int rxoff; /* Current offset within RX buffer */
char tmpbuf[16]; /* Buffer to hold small strings */
int tmplen; /* Number of bytes used in tmpbuffer */
int state; /* Current state of the parser */
int ret; /* Return value from internal calls */
- char * headerbuf;
+ char *headerbuf;
int headerlen;
- char * end;
+ char *end;
Review Comment:
```suggestion
FAR char *end;
```
##########
system/nxrecorder/nxrecorder.c:
##########
@@ -225,21 +225,21 @@ static int nxrecorder_enqueuebuffer(FAR struct nxrecorder_s *precorder,
static void *nxrecorder_recordthread(pthread_addr_t pvarg)
{
- struct nxrecorder_s *precorder = (struct nxrecorder_s *)pvarg;
- struct audio_msg_s msg;
- struct audio_buf_desc_s buf_desc;
- ssize_t size;
- bool running = true;
- bool streaming = true;
- bool failed = false;
- struct ap_buffer_info_s buf_info;
- FAR struct ap_buffer_s **pbuffers;
- unsigned int prio;
+ struct nxrecorder_s *precorder = (struct nxrecorder_s *)pvarg;
Review Comment:
```suggestion
FAR struct nxrecorder_s *precorder = (FAR struct nxrecorder_s *)pvarg;
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -74,9 +74,9 @@
#ifdef CONFIG_NXPLAYER_FMT_FROM_EXT
struct nxplayer_ext_fmt_s
{
- const char *ext;
- uint16_t format;
- CODE int (*getsubformat)(int fd);
+ const char *ext;
Review Comment:
```suggestion
FAR const char *ext;
```
##########
system/zmodem/zm_send.c:
##########
@@ -1596,7 +1596,7 @@ ZMSHANDLE zms_initialize(int remfd)
* or command if it were not already active.
*/
- nwritten = zm_remwrite(pzm->remfd, (uint8_t *) "rz\r", 3);
+ nwritten = zm_remwrite(pzm->remfd, (uint8_t *)"rz\r", 3);
Review Comment:
```suggestion
nwritten = zm_remwrite(pzm->remfd, (FAR uint8_t *)"rz\r", 3);
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -752,21 +752,21 @@ static int nxplayer_enqueuebuffer(FAR struct nxplayer_s *pplayer,
static void *nxplayer_playthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *nxplayer_playthread(pthread_addr_t pvarg)
```
##########
system/nxplayer/nxplayer.c:
##########
@@ -752,21 +752,21 @@ static int nxplayer_enqueuebuffer(FAR struct nxplayer_s *pplayer,
static void *nxplayer_playthread(pthread_addr_t pvarg)
{
- struct nxplayer_s *pplayer = (struct nxplayer_s *)pvarg;
- struct audio_msg_s msg;
- struct audio_buf_desc_s buf_desc;
- ssize_t size;
- bool running = true;
- bool streaming = true;
- bool failed = false;
- struct ap_buffer_info_s buf_info;
- FAR struct ap_buffer_s **buffers;
- unsigned int prio;
+ struct nxplayer_s *pplayer = (struct nxplayer_s *)pvarg;
Review Comment:
```suggestion
FAR struct nxplayer_s *pplayer = (FAR struct nxplayer_s *)pvarg;
```
##########
system/termcurses/tcurses_vt100.c:
##########
@@ -1126,8 +1126,8 @@ static int tcurses_vt100_getkeycode(FAR struct termcurses_s *dev,
FAR int *specialkey,
FAR int *keymodifiers)
{
- FAR struct tcurses_vt100_s *priv;
- const struct keycodes_s *pkeycodes;
+ FAR struct tcurses_vt100_s *priv;
+ const struct keycodes_s *pkeycodes;
Review Comment:
```suggestion
FAR const struct keycodes_s *pkeycodes;
```
##########
system/nxrecorder/nxrecorder.c:
##########
@@ -225,21 +225,21 @@ static int nxrecorder_enqueuebuffer(FAR struct nxrecorder_s *precorder,
static void *nxrecorder_recordthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *nxrecorder_recordthread(pthread_addr_t pvarg)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992061835
##########
examples/pipe/interlock_test.c:
##########
@@ -69,9 +69,10 @@ static void *null_writer(pthread_addr_t pvarg)
fd = open(FIFO_PATH2, O_WRONLY);
if (fd < 0)
{
- fprintf(stderr, "null_writer: Failed to open FIFO %s for writing, errno=%d\n",
+ fprintf(stderr, "null_writer: "
+ "Failed to open FIFO %s for writing, errno=%d\n",
FIFO_PATH2, errno);
- return (void*)1;
+ return (void *)1;
Review Comment:
The whole code base doesn't use FAR, so it's better to move to new patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r993070592
##########
examples/netloop/lo_listener.c:
##########
@@ -297,7 +299,7 @@ void *lo_listener(pthread_addr_t pvarg)
memset(&nls, 0, sizeof(struct net_listener_s));
if (!net_mksocket(&nls))
{
- return (void*)1;
+ return (void *)(uintptr_t)1;
Review Comment:
let's fix style issue at line 113 as well
##########
netutils/thttpd/cgi-src/ssi.c:
##########
@@ -99,81 +99,82 @@ static void internal_error(char *reason)
{
char *title = "500 Internal Error";
- printf("\
-<HTML><HEAD><TITLE>%s</TITLE></HEAD>\n\
-<BODY><H2>%s</H2>\n\
-Something unusual went wrong during a server-side-includes request:\n\
-<BLOCKQUOTE>\n\
-%s\n\
-</BLOCKQUOTE>\n\
-</BODY></HTML>\n", title, title, reason);
+ printf("<HTML><HEAD><TITLE>%s</TITLE></HEAD>\n"
+ "<BODY><H2>%s</H2>\n"
+ "Something unusual went wrong during a server-side-includes request:\n"
+ "<BLOCKQUOTE>\n"
+ "%s\n"
+ "</BLOCKQUOTE>\n"
+ "</BODY></HTML>\n",
+ title, title, reason);
Review Comment:
```suggestion
printf("<HTML><HEAD><TITLE>%s</TITLE></HEAD>\n"
"<BODY><H2>%s</H2>\n"
"Something unusual went wrong during a server-side-includes request:\n"
"<BLOCKQUOTE>\n"
"%s\n"
"</BLOCKQUOTE>\n"
"</BODY></HTML>\n",
title, title, reason);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991498162
##########
system/nxplayer/nxplayer.c:
##########
@@ -752,21 +752,21 @@ static int nxplayer_enqueuebuffer(FAR struct nxplayer_s *pplayer,
static void *nxplayer_playthread(pthread_addr_t pvarg)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991495615
##########
netutils/libcurl4nx/curl4nx_easy_perform.c:
##########
@@ -140,15 +140,15 @@ static int curl4nx_is_header(FAR char *buf, int len,
int curl4nx_easy_perform(FAR struct curl4nx_s *handle)
{
struct sockaddr_in server;
- FILE * stream; /* IOSTREAM used to printf in the socket TODO avoid */
+ FILE *stream; /* IOSTREAM used to printf in the socket TODO avoid */
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991497220
##########
system/termcurses/tcurses_vt100.c:
##########
@@ -1126,8 +1126,8 @@ static int tcurses_vt100_getkeycode(FAR struct termcurses_s *dev,
FAR int *specialkey,
FAR int *keymodifiers)
{
- FAR struct tcurses_vt100_s *priv;
- const struct keycodes_s *pkeycodes;
+ FAR struct tcurses_vt100_s *priv;
+ const struct keycodes_s *pkeycodes;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1340:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r991496604
##########
system/zmodem/zm_send.c:
##########
@@ -1596,7 +1596,7 @@ ZMSHANDLE zms_initialize(int remfd)
* or command if it were not already active.
*/
- nwritten = zm_remwrite(pzm->remfd, (uint8_t *) "rz\r", 3);
+ nwritten = zm_remwrite(pzm->remfd, (uint8_t *)"rz\r", 3);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org