You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/03/07 19:03:52 UTC
Re: Review Request 43725: Fix GEODE-944: ServerLauncherJUnitTest
fails when ISP redirects DNS failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43725/#review122316
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On Feb. 24, 2016, 12:31 a.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43725/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 12:31 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, Jinmei Liao, Kirk Lund, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Remove the expected exception since the DNS lookup result is non-deterministic due to ISP DNS hijacking. Do not re-throw the exception in the catch block.
>
> Do the same for LocatorLauncherJUnitTest as well.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java b0be89f
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java f13bb73
> geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 9a74abd
>
> Diff: https://reviews.apache.org/r/43725/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>