You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/26 13:33:59 UTC

[GitHub] [camel] fg78nc opened a new pull request #4516: Update loadBalance-eip.adoc

fg78nc opened a new pull request #4516:
URL: https://github.com/apache/camel/pull/4516


   Correct Integer type declaration


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] fg78nc commented on pull request #4516: Update loadBalance-eip.adoc

Posted by GitBox <gi...@apache.org>.
fg78nc commented on pull request #4516:
URL: https://github.com/apache/camel/pull/4516#issuecomment-716568707


   Ok, I will work on it.
   Can you merge my previous PR with a Type Converter example
   https://github.com/apache/camel-spring-boot-examples/pull/18 ?
   
   
   On Mon, Oct 26, 2020 at 10:03 AM Andrea Cosentino <no...@github.com>
   wrote:
   
   > If you time and will, sure. An example would be good.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/camel/pull/4516#issuecomment-716567079>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AEOCGNEKTHZWGJDIKSFTFT3SMV6UFANCNFSM4S7MKCVQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd commented on pull request #4516: Update loadBalance-eip.adoc

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4516:
URL: https://github.com/apache/camel/pull/4516#issuecomment-716563358


   Yeah, go ahead please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd commented on pull request #4516: Update loadBalance-eip.adoc

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4516:
URL: https://github.com/apache/camel/pull/4516#issuecomment-716550068


   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd merged pull request #4516: Update loadBalance-eip.adoc

Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #4516:
URL: https://github.com/apache/camel/pull/4516


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] fg78nc commented on pull request #4516: Update loadBalance-eip.adoc

Posted by GitBox <gi...@apache.org>.
fg78nc commented on pull request #4516:
URL: https://github.com/apache/camel/pull/4516#issuecomment-716566273


   Done, please review.
   I also noticed the weighted algorithm is not working exactly as expected -
   the first batch is not distributed as per request.
   Would you like me to create examples and push to Camel Spring Boot examples?
   
   On Mon, Oct 26, 2020 at 9:57 AM Andrea Cosentino <no...@github.com>
   wrote:
   
   > Yeah, go ahead please
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/camel/pull/4516#issuecomment-716563358>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AEOCGNDMRW5IRLQLDDLCOQDSMV56HANCNFSM4S7MKCVQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] fg78nc commented on pull request #4516: Update loadBalance-eip.adoc

Posted by GitBox <gi...@apache.org>.
fg78nc commented on pull request #4516:
URL: https://github.com/apache/camel/pull/4516#issuecomment-716556718


   Actually, I just tested and seems like API has changed weighted accepts a String and optional delimiter.
   Do you want me to update the docs?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd commented on pull request #4516: Update loadBalance-eip.adoc

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4516:
URL: https://github.com/apache/camel/pull/4516#issuecomment-716567079


   If you time and will, sure. An example would be good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org