You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@myfaces.apache.org by gc...@apache.org on 2011/03/23 18:48:07 UTC

svn commit: r1084651 - /myfaces/trinidad/trunk/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java

Author: gcrawford
Date: Wed Mar 23 17:48:07 2011
New Revision: 1084651

URL: http://svn.apache.org/viewvc?rev=1084651&view=rev
Log:
TRINIDAD-2064 UIXEditableValue.compareValues() shouldn't return false for 'empty' strings of different lengths

Thanks to Mark Yvanovich

Modified:
    myfaces/trinidad/trunk/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java

Modified: myfaces/trinidad/trunk/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java?rev=1084651&r1=1084650&r2=1084651&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java (original)
+++ myfaces/trinidad/trunk/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXEditableValueTemplate.java Wed Mar 23 17:48:07 2011
@@ -503,8 +503,8 @@ abstract public class UIXEditableValueTe
   protected boolean compareValues(Object previous, Object value)
   {
     // handle cases where previous value was empty
-    if (isEmpty(previous)) // bug 4268807
-      return !isEmpty(value);
+    if (previous == null || "".equals(previous)) // bug 4268807
+      return !(value == null || "".equals(value));
 
     boolean isNotEqual = !previous.equals(value);