You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "stephen mallette (JIRA)" <ji...@apache.org> on 2019/05/07 20:36:00 UTC

[jira] [Closed] (TINKERPOP-2189) ConnectedComponent test assumes fixed order of vertices

     [ https://issues.apache.org/jira/browse/TINKERPOP-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stephen mallette closed TINKERPOP-2189.
---------------------------------------
       Resolution: Fixed
         Assignee: stephen mallette
    Fix Version/s: 3.4.2

Should be fixed with this:

https://github.com/apache/tinkerpop/commit/fea8882635ab3cf4345747bb47bde9d0d4067807

I didn't fix GLV tests because.....well...I'm not sure how. They don't have complex assertion logic so, it's trickier. I could have done something more radical and changed the nature of the test, but perhaps this is fine for now. GLV tests only test TinkerGraph so they should be consistent.

> ConnectedComponent test assumes fixed order of vertices
> -------------------------------------------------------
>
>                 Key: TINKERPOP-2189
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2189
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: test-suite
>    Affects Versions: 3.4.1
>            Reporter: Florian Hockmann
>            Assignee: stephen mallette
>            Priority: Trivial
>             Fix For: 3.4.2
>
>
> The test {{g_V_hasLabelXsoftwareX_connectedComponent_project_byXnameX_byXcomponentX}} checks that the two vertices {{lop}} and {{ripple}} are in the same component. It does that [by asserting that these vertices have the id|https://github.com/apache/tinkerpop/blob/6a705098b5176086c667b94fa9e13aa2f122bb59/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConnectedComponentTest.java#L76] of the {{marko}} vertex as their component.
> The id used for the component is [simply the id of the vertex on which the program is executed first|https://github.com/apache/tinkerpop/blob/667134d608ca29828457cd3eebe365ee1fd330ce/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/connected/ConnectedComponentVertexProgram.java#L122].
> So, the test fails if the program is executed first for another vertex even if the connected component is created correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)