You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by suvam97 <gi...@git.apache.org> on 2016/06/22 09:47:46 UTC

[GitHub] zeppelin pull request #1066: [ZEPPELIN-1047] Add filter to handle upper case

GitHub user suvam97 opened a pull request:

    https://github.com/apache/zeppelin/pull/1066

    [ZEPPELIN-1047] Add filter to handle upper case

    ### What is this PR for?
    The notebook filter in navbar does not filter the results of note if note name is given in upper case .
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    ### What is the Jira issue?
    [ZEPPELIN-1047](https://issues.apache.org/jira/browse/ZEPPELIN-1047)
    
    ### How should this be tested?
    1.Open the notebook filter under navbar -> Notebook menu.
    2.Search for any note by giving name in upper case.
    3.You should be able to search all the note book names irrespective of case. 
    
    ### Screenshots (if appropriate)
    
    **BEFORE:**
    http://g.recordit.co/jqo7DYXStI.gif
    
    **AFTER:**
    http://g.recordit.co/uuCT79uEti.gif
    
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/suvam97/zeppelin ZEPPELIN-1047

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1066
    
----
commit 5f176cb2fa9eaf9b738960e4e5aa24ae8a71a5e7
Author: suvam97 <su...@gmail.com>
Date:   2016-06-22T09:37:09Z

    Add filter to hamdle upper case

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

Posted by suvam97 <gi...@git.apache.org>.

Github user suvam97 commented on the issue:

    https://github.com/apache/zeppelin/pull/1066
  
    @minahlee Conflict resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

Posted by suvam97 <gi...@git.apache.org>.

Github user suvam97 commented on the issue:

    https://github.com/apache/zeppelin/pull/1066
  
    @minahlee Conflict Resolved


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

Posted by suvam97 <gi...@git.apache.org>.

Github user suvam97 commented on the issue:

    https://github.com/apache/zeppelin/pull/1066
  
    @corneadoug : sorry for late response ! Changes updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1066
  
    @suvam97 Maybe you should try building from master and cleaning your cache.
    Current filtering is working perfectly for me
    ![notebookisrunnable](https://cloud.githubusercontent.com/assets/710411/16262788/295d83ba-38ac-11e6-8a2a-3e09875387ab.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

Posted by minahlee <gi...@git.apache.org>.

Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1066
  
    @suvam97 Could you rebase master and resolve conflicts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1066
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1066
  
    @suvam97 Sorry, I was actually testing your branch :)
    Works, great, could you then delete the `notebookFilter` since it is not being used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---