[GitHub] [arrow] mapleFU commented on a diff in pull request #37016: GH-37014: [C++][Parquet] Preserve some Parquet distinct counts when merging stats

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #37016:
URL: https://github.com/apache/arrow/pull/37016#discussion_r1283978568


##########
cpp/src/parquet/statistics.cc:
##########
@@ -621,7 +628,9 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
       // num_values_ is reliable and it means number of non-null values.
       s.all_null_value = num_values_ == 0;
     }
-    // TODO (GH-36505): distinct count is not encoded for now.
+    if (HasDistinctCount()) {

Review Comment:
   Yes, previously I think we can write it, but pirtou mentioned that it's bug-prone, and other implemention didn't write that. So I set it not encoded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org