[jira] Commented: (WICKET-2871) Component registers feedback messages badly

["Jeremy Thomerson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867544#action_12867544 ] 

Jeremy Thomerson commented on WICKET-2871:
------------------------------------------

One more thing.  You can certainly submit patches in the future.  We welcome this.  But, it would be helpful to us if you could submit a patch that is generated from the source tree.  By copying and pasting files, you got the filenames wrong and the patch backwards.  What you need to do to generate a patch is this:

svn co http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.x
cd wicket-1.4.x

# make your changes to the code tree

# it would be nice if you ran this since it will test that you didn't break anything
mvn clean install

# now, generate the patch:
svn diff > /tmp/wicket-2871.patch

That will generate a nice patch that we can easily apply, review, and test.  We are very busy and doing this for free.  Anything you can do to help is much appreciated.

> Component registers feedback messages badly
> -------------------------------------------
>
>                 Key: WICKET-2871
>                 URL: https://issues.apache.org/jira/browse/WICKET-2871
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8
>         Environment: Windows 7
> Wicket 1.4.7
>            Reporter: Hielke Hoeve
>            Assignee: Jeremy Thomerson
>            Priority: Trivial
>         Attachments: Session.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Component registers feedback messages by adding them to the FeedbackMessages class directly while there are special functions in Session to do this. 
> Component should call Session.get().error(message) in the following example. I have attached a patch file which fixes this.
> Example:
> Component.class
> public final void error(final Serializable message)
> {
> 	Session.get().getFeedbackMessages().error(this, message);
> 	Session.get().dirty();
> }
> Session.class:
> public final void error(final String message)
> {
> 	addFeedbackMessage(message, FeedbackMessage.ERROR);
> }
> private void addFeedbackMessage(String message, int level)
> {
> 	getFeedbackMessages().add(null, message, level);
> 	dirty();
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.