You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/02 21:25:04 UTC

[GitHub] [arrow-datafusion] jgoday edited a comment on pull request #819: Draft: python bindings for window functions

jgoday edited a comment on pull request #819:
URL: https://github.com/apache/arrow-datafusion/pull/819#issuecomment-891341609


   There is some pending issues:
   
   1. Currently, only a generic way of calling window functions by name is exported. Should we export all window functions individually ?
      ```rust
      fn window(
          name: &str,
          args: Vec<expression::Expression>,
          partition_by: Option<Vec<expression::Expression>>,
          order_by: Option<Vec<expression::Expression>>,
      ) -> PyResult<expression::Expression> {
      ```
   2. There is some functionality copied from internal datafusion::sql::utils crate,
   to find window expressions and wrap a logical plan into a LogicalPlan::Window.
      I have changed python crate datafusion dependency (to local project).
      ```toml
      datafusion = { path = "../datafusion" }
       ```
      **Obviously this change is completely wrong and temporal**,
      just to allow using internal datafusion::sql::utils from python crate (find_window_exprs and  group_window_expr_by_sort_keys).
      - Would it be better to duplicate the code so as not to change the visibility of that internal crate and functions currently public(crate) ?
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org