You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/06/21 13:04:27 UTC
[GitHub] [kylin] codecov-io edited a comment on issue #706: KYLIN-4012
optimize cache in TrieDictionary/TrieDictionaryForest
codecov-io edited a comment on issue #706: KYLIN-4012 optimize cache in TrieDictionary/TrieDictionaryForest
URL: https://github.com/apache/kylin/pull/706#issuecomment-504344241
# [Codecov](https://codecov.io/gh/apache/kylin/pull/706?src=pr&el=h1) Report
> Merging [#706](https://codecov.io/gh/apache/kylin/pull/706?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/970899011211b285b78cfc3a63ac5025436ddb59?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `90.32%`.
[](https://codecov.io/gh/apache/kylin/pull/706?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #706 +/- ##
============================================
- Coverage 25.73% 25.72% -0.01%
+ Complexity 6013 6011 -2
============================================
Files 1385 1385
Lines 82424 82415 -9
Branches 11557 11552 -5
============================================
- Hits 21211 21202 -9
- Misses 59170 59173 +3
+ Partials 2043 2040 -3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/706?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/706/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.92% <0%> (-0.02%)` | `42 <0> (ø)` | |
| [...in/java/org/apache/kylin/dict/CacheDictionary.java](https://codecov.io/gh/apache/kylin/pull/706/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0NhY2hlRGljdGlvbmFyeS5qYXZh) | `95.45% <96.55%> (+17.67%)` | `15 <11> (+1)` | :arrow_up: |
| [...apache/kylin/dict/TrieDictionaryForestBuilder.java](https://codecov.io/gh/apache/kylin/pull/706/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5Rm9yZXN0QnVpbGRlci5qYXZh) | `88.88% <0%> (-4.94%)` | `23% <0%> (-1%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/706/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | |
| [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/706/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0%> (-3.04%)` | `21% <0%> (-1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/706/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/706/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/706?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/706?src=pr&el=footer). Last update [9708990...ec0edcf](https://codecov.io/gh/apache/kylin/pull/706?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services