[GitHub] [superset] Usiel commented on pull request #22849: fix(cache): removeunused webserver config & handle trailing slashes

["Usiel (via GitHub)" <gi...@apache.org>]

Usiel commented on PR #22849:
URL: https://github.com/apache/superset/pull/22849#issuecomment-1525879656

   > Bumping this since I see someone is getting confused by the out-of-date docs that this would have fixed: #22849 Maybe merge this to fix the docs, then address the suggestion from @Antonio-RiveroMartnez about fixing trailing URLs in a different PR?
   
   My apologies, I kinda forgot to push my changes and post a comment :) 
   
   I would tend to go with the simple doc fix in this PR only (as suggested), meaning we would only merge the first commit [4eaca42](https://github.com/apache/superset/pull/22849/commits/4eaca423fd2e8c5f39b79c3a0cd92e5d80da961d). 
   I still pushed the fix for trailing slashes ([0bfe0d7](https://github.com/apache/superset/pull/22849/commits/0bfe0d7a10c47299f42d9ed95a05134a087547aa)) in case we just want to merge it immediately, but I'm also happy to extract that change and work on it on a separate PR; we do not have any tests for the `tasks.cache` module at the moment - could be a good time to get started on that, but it will require more time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org