You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/09/22 20:18:44 UTC
[jira] Created: (HADOOP-4242) Remove an extra ";" in FSDirectory
Remove an extra ";" in FSDirectory
----------------------------------
Key: HADOOP-4242
URL: https://issues.apache.org/jira/browse/HADOOP-4242
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Priority: Blocker
Fix For: 0.19.0
In FSDirectory,
{code}
import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
{code}
Eclipse complains that
{noformat}
Syntax error on token ";", delete this token.
{noformat}
but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633666#action_12633666 ]
Steve Loughran commented on HADOOP-4242:
----------------------------------------
I see this in IDEA too; thought it was that IDE only. Looks like the IDEs have a stricter model of what is legal than javac itself.
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4242:
-------------------------------------------
Status: Patch Available (was: Open)
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633776#action_12633776 ]
Hudson commented on HADOOP-4242:
--------------------------------
Integrated in Hadoop-trunk #612 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/612/])
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-4242:
---------------------------------
Fix Version/s: (was: 0.20.0)
0.19.0
I committed this to 0.19 since HADOOP-4006 that introduced this bug got committed to 0.19.
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634135#action_12634135 ]
Hudson commented on HADOOP-4242:
--------------------------------
Integrated in Hadoop-trunk #613 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/613/])
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4242:
-------------------------------------------
Attachment: 4242_20080922.patch
4242_20080922.patch: removed ";"
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4242:
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.19.0)
0.20.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Nicholas!
Note that the line with the problem was not in the 0.19 branch.
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633545#action_12633545 ]
Hadoop QA commented on HADOOP-4242:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390668/4242_20080922.patch
against trunk revision 697306.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3346/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3346/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3346/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3346/console
This message is automatically generated.
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4242) Remove an extra ";" in FSDirectory
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633668#action_12633668 ]
Steve Loughran commented on HADOOP-4242:
----------------------------------------
so: +1 for this patch :).
> Remove an extra ";" in FSDirectory
> ----------------------------------
>
> Key: HADOOP-4242
> URL: https://issues.apache.org/jira/browse/HADOOP-4242
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4242_20080922.patch
>
>
> In FSDirectory,
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsConstants.StartupOption;;
> {code}
> Eclipse complains that
> {noformat}
> Syntax error on token ";", delete this token.
> {noformat}
> but javac seems okay about it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.