You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/20 14:16:38 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

gustavonihei commented on code in PR #6302:
URL: https://github.com/apache/incubator-nuttx/pull/6302#discussion_r878196043


##########
arch/xtensa/src/common/xtensa_coproc.S:
##########
@@ -70,13 +68,11 @@ _xtensa_coproc_saoffsets:
   .size	_xtensa_coproc_saoffsets, . - _xtensa_coproc_saoffsets
 
 /****************************************************************************
- * Public Functions
+ * Pre-processor Definitions
  ****************************************************************************/
 
-  .text
-
 /****************************************************************************
- * Name: _xtensa_coproc_savestate
+ * Marco: xtensa_coproc_savestate

Review Comment:
   ```suggestion
    * Macro: xtensa_coproc_savestate
   ```
   nit: Small typo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org