[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #765: nimble/host: Fix check for valid static random address

[GitBox <gi...@apache.org>]

prasad-alatkar commented on a change in pull request #765: nimble/host: Fix check for valid static random address
URL: https://github.com/apache/mynewt-nimble/pull/765#discussion_r388720848
 
 

 ##########
 File path: nimble/host/src/ble_hs_id.c
 ##########
 @@ -58,14 +58,20 @@ ble_hs_id_set_rnd(const uint8_t *rnd_addr)
 {
     uint8_t addr_type_byte;
     int rc;
-    uint8_t all_zeros[BLE_DEV_ADDR_LEN] = {0}, all_ones[BLE_DEV_ADDR_LEN] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF};
+    int i, rnd_part_sum = 0;
 
 
 Review comment:
   Sure @sjanc and yes I agree that your suggested changes (almost all) are more readable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services