You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/10 06:09:10 UTC
[GitHub] [flink] TsReaper commented on a change in pull request #10797:
[FLINK-15172][table-blink] Optimize the operator algorithm to lazily
allocate memory
TsReaper commented on a change in pull request #10797: [FLINK-15172][table-blink] Optimize the operator algorithm to lazily allocate memory
URL: https://github.com/apache/flink/pull/10797#discussion_r365084839
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/sort/BinaryExternalSorter.java
##########
@@ -1054,7 +1018,7 @@ private void releaseEmptyBuffers() {
}
}
}
- releaseCoreSegments();
+ sortReadMemory.forEach(LazyMemorySegmentPool::cleanCache);
Review comment:
We don't need to manually clean cache, as memory pool will try to clean cache when a segment is returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services