You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/12/16 20:37:00 UTC
Re: Review Request 54718: Removed dependency of `recover` on cached
networks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54718/
-----------------------------------------------------------
(Updated Dec. 16, 2016, 8:36 p.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Changes
-------
Rebased.
Summary (updated)
-----------------
Removed dependency of `recover` on cached networks.
Bugs: MESOS-6567
https://issues.apache.org/jira/browse/MESOS-6567
Repository: mesos
Description
-------
Since CNI networks can be added and removed on the fly, and for a
given container the CNI configuration with which the container was
launched is check-pointed in the containers `network/cni` work
directory, it doesn't make sense to require the network name that the
container is associated with to exist in the in-memory cache. Hence,
removing these dependencies.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049
Diff: https://reviews.apache.org/r/54718/diff/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 54718: Removed dependency of `recover` on cached
networks.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54718/#review159529
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 16, 2016, 8:36 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54718/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2016, 8:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-6567
> https://issues.apache.org/jira/browse/MESOS-6567
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since CNI networks can be added and removed on the fly, and for a
> given container the CNI configuration with which the container was
> launched is check-pointed in the containers `network/cni` work
> directory, it doesn't make sense to require the network name that the
> container is associated with to exist in the in-memory cache. Hence,
> removing these dependencies.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049
>
> Diff: https://reviews.apache.org/r/54718/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 54718: Removed dependency of `recover` on cached
networks.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54718/#review159555
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Dec. 17, 2016, 4:36 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54718/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2016, 4:36 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-6567
> https://issues.apache.org/jira/browse/MESOS-6567
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since CNI networks can be added and removed on the fly, and for a
> given container the CNI configuration with which the container was
> launched is check-pointed in the containers `network/cni` work
> directory, it doesn't make sense to require the network name that the
> container is associated with to exist in the in-memory cache. Hence,
> removing these dependencies.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049
>
> Diff: https://reviews.apache.org/r/54718/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>