You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by rakeshadr <gi...@git.apache.org> on 2017/01/23 05:51:39 UTC
[GitHub] zookeeper pull request #153: ZOOKEEPER-2671: Fix compilation error in branch...
GitHub user rakeshadr opened a pull request:
https://github.com/apache/zookeeper/pull/153
ZOOKEEPER-2671: Fix compilation error in branch-3.4
Creating the PR on behalf of Arshad.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rakeshadr/zookeeper-1 ZK-2671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit 47e6b58609c3aa52f989d22204b5dd4acca5dade
Author: Rakesh Radhakrishnan <ra...@apache.org>
Date: 2017-01-23T05:49:02Z
ZOOKEEPER-2671: Fix compilation error in branch-3.4
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #153: ZOOKEEPER-2671: Fix compilation error in branch...
Posted by arshadmohammad <gi...@git.apache.org>.
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/153#discussion_r97257715
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -664,4 +664,32 @@ public static String join(String separator, Object[] parts) {
}
return sb.toString();
}
+
+ public static ZooKeeper createZKClient(String cxnString) throws Exception {
+ return createZKClient(cxnString, CONNECTION_TIMEOUT);
+ }
+
+ /**
+ * Returns ZooKeeper client after connecting to ZooKeeper Server. Session
+ * timeout is {@link #CONNECTION_TIMEOUT}
+ *
+ * @param cxnString
+ * connection string in the form of host:port
+ * @param sessionTimeout
+ * @throws IOException
+ * in cases of network failure
+ */
+ public static ZooKeeper createZKClient(String cxnString, int sessionTimeout) throws IOException {
+ CountdownWatcher watcher = new CountdownWatcher();
+ ZooKeeper zk = new ZooKeeper(cxnString, sessionTimeout, watcher);
+ try {
+ watcher.waitForConnected(CONNECTION_TIMEOUT);
+ } catch (InterruptedException e) {
+ Assert.fail("ZooKeeper client can not connect to " + cxnString);
+ }
+ catch (TimeoutException e) {
+ Assert.fail("ZooKeeper client can not connect to " + cxnString);
+ }
+ return zk;
+ }
}
--- End diff --
Thanks Rakesh.
Changes LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #153: ZOOKEEPER-2671: Fix compilation error in branch...
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr closed the pull request at:
https://github.com/apache/zookeeper/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #153: ZOOKEEPER-2671: Fix compilation error in branch-3.4
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/153
Closing the PR manually as this is merged to b-3.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---