You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/08/12 18:03:33 UTC

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.


> On July 28, 2015, 7:20 p.m., Timothy Chen wrote:
> > I notice there are no new tests added for this, can you add a test to verify the new change works?

Are you able to add this? Otherwise let's add a TODO and get this in.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review93329
-----------------------------------------------------------


On July 24, 2015, 1:07 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 1:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
>     https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>