You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Don Brown <mr...@twdata.org> on 2005/08/29 02:33:54 UTC
requiredif deprecated?
Is requiredif deprecated? The documentation [1] indicates it is,
however, I can see no evidence of that in the source code. In
particular, the validateRequiredIf() method of o.a.s.v.FieldChecks
hasn't been marked as such.
Whatever it is, we should at least be consistent about it.
Don
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: requiredif deprecated?
Posted by Rob Leland <le...@speakeasy.net>.
Don Brown wrote:
> Is requiredif deprecated? The documentation [1] indicates it is,
> however, I can see no evidence of that in the source code. In
> particular, the validateRequiredIf() method of o.a.s.v.FieldChecks
> hasn't been marked as such.
I believe validWhen is server side only.
The functionality is still useful on the client side.
>
> Whatever it is, we should at least be consistent about it.
>
> Don
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: requiredif deprecated?
Posted by Don Brown <mr...@twdata.org>.
[1] http://struts.apache.org/userGuide/dev_validator.html
Don Brown wrote:
> Is requiredif deprecated? The documentation [1] indicates it is,
> however, I can see no evidence of that in the source code. In
> particular, the validateRequiredIf() method of o.a.s.v.FieldChecks
> hasn't been marked as such.
>
> Whatever it is, we should at least be consistent about it.
>
> Don
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: requiredif deprecated?
Posted by Joe Germuska <Jo...@Germuska.com>.
At 7:34 AM -0400 8/29/05, Ted Husted wrote:
>Hmmm, I think this is the part where we say, "Thanks for volunteering, Don."
>:)
>
>If you'd like to see the JEXL patch in version 1.3.0, then, please, have at
>it :)
Well, there's a fair amount of hemming and hawing in the comment
history for that ticket in Bugzilla. There were concerns about
dependencies and such, and I was basically just waiting for more
consensus before committing it.
I've got people on my team using it by copy in a few places and
people are pretty satisfied with it, although it did flush out that
html:javascript bug -- and in addition to what was reported in
Bugzilla, there are also problems if you use line-breaks in your JEXL
expression -- those also need to be escaped, but I don't think it was
mentioned in the ticket.
But anyway, in general, it is pretty neat. If folks think that all
the questions which were raised in Bugzilla are either settled or
unimportant, I should be able to commit it today or tomorrow.
Joe
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"Narrow minds are weapons made for mass destruction" -The Ex
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: requiredif deprecated?
Posted by Ted Husted <te...@gmail.com>.
Hmmm, I think this is the part where we say, "Thanks for volunteering, Don."
:)
If you'd like to see the JEXL patch in version 1.3.0, then, please, have at
it :)
-Ted.
On 8/29/05, Don Brown <mr...@twdata.org> wrote:
>
> I like the jexl el validator. What is holding that patch up?
>
> Don
>
> Niall Pemberton wrote:
> > I'm not convinced that validwhen is\was such a great replacement for
> > requiredif. I think it has caused as much confusion as requiredif did
> Maybe
> > the EL Validator thats been proposed will be better and we should hold
> off
> > removing requiredif until thats available as a replacement:
> >
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=34849
> >
> > Niall
> >
> > ----- Original Message -----
> > From: "Martin Cooper" <mf...@gmail.com>
> > Sent: Monday, August 29, 2005 2:57 AM
> >
> >
> > On 8/28/05, Don Brown <mr...@twdata.org> wrote:
> >
> >>Is requiredif deprecated? The documentation [1] indicates it is,
> >>however, I can see no evidence of that in the source code. In
> >>particular, the validateRequiredIf() method of o.a.s.v.FieldChecks
> >>hasn't been marked as such.
> >
> >
> > It looks like James Turner deprecated it (or intended to) in April 2003:
> >
> > http://marc.theaimsgroup.com/?l=struts-dev&m=105042119528289&w=2
> >
> > but as you've observed, the deprecation only happened in the docs and
> > not the code.
> >
> > If we're all happy with validwhen as the replacement, we should get
> > rid of the requiredif code, IMO. I'm not sure we need to go through
> > the process of deprecating the source for another release before we do
> > that.
> >
> > --
> > Martin Cooper
> >
> >
> >
> >>Whatever it is, we should at least be consistent about it.
> >>
> >>Don
Re: requiredif deprecated?
Posted by Don Brown <mr...@twdata.org>.
I like the jexl el validator. What is holding that patch up?
Don
Niall Pemberton wrote:
> I'm not convinced that validwhen is\was such a great replacement for
> requiredif. I think it has caused as much confusion as requiredif did Maybe
> the EL Validator thats been proposed will be better and we should hold off
> removing requiredif until thats available as a replacement:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=34849
>
> Niall
>
> ----- Original Message -----
> From: "Martin Cooper" <mf...@gmail.com>
> Sent: Monday, August 29, 2005 2:57 AM
>
>
> On 8/28/05, Don Brown <mr...@twdata.org> wrote:
>
>>Is requiredif deprecated? The documentation [1] indicates it is,
>>however, I can see no evidence of that in the source code. In
>>particular, the validateRequiredIf() method of o.a.s.v.FieldChecks
>>hasn't been marked as such.
>
>
> It looks like James Turner deprecated it (or intended to) in April 2003:
>
> http://marc.theaimsgroup.com/?l=struts-dev&m=105042119528289&w=2
>
> but as you've observed, the deprecation only happened in the docs and
> not the code.
>
> If we're all happy with validwhen as the replacement, we should get
> rid of the requiredif code, IMO. I'm not sure we need to go through
> the process of deprecating the source for another release before we do
> that.
>
> --
> Martin Cooper
>
>
>
>>Whatever it is, we should at least be consistent about it.
>>
>>Don
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: requiredif deprecated?
Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
I'm not convinced that validwhen is\was such a great replacement for
requiredif. I think it has caused as much confusion as requiredif did Maybe
the EL Validator thats been proposed will be better and we should hold off
removing requiredif until thats available as a replacement:
http://issues.apache.org/bugzilla/show_bug.cgi?id=34849
Niall
----- Original Message -----
From: "Martin Cooper" <mf...@gmail.com>
Sent: Monday, August 29, 2005 2:57 AM
On 8/28/05, Don Brown <mr...@twdata.org> wrote:
> Is requiredif deprecated? The documentation [1] indicates it is,
> however, I can see no evidence of that in the source code. In
> particular, the validateRequiredIf() method of o.a.s.v.FieldChecks
> hasn't been marked as such.
It looks like James Turner deprecated it (or intended to) in April 2003:
http://marc.theaimsgroup.com/?l=struts-dev&m=105042119528289&w=2
but as you've observed, the deprecation only happened in the docs and
not the code.
If we're all happy with validwhen as the replacement, we should get
rid of the requiredif code, IMO. I'm not sure we need to go through
the process of deprecating the source for another release before we do
that.
--
Martin Cooper
> Whatever it is, we should at least be consistent about it.
>
> Don
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: requiredif deprecated?
Posted by Martin Cooper <mf...@gmail.com>.
On 8/28/05, Don Brown <mr...@twdata.org> wrote:
> Is requiredif deprecated? The documentation [1] indicates it is,
> however, I can see no evidence of that in the source code. In
> particular, the validateRequiredIf() method of o.a.s.v.FieldChecks
> hasn't been marked as such.
It looks like James Turner deprecated it (or intended to) in April 2003:
http://marc.theaimsgroup.com/?l=struts-dev&m=105042119528289&w=2
but as you've observed, the deprecation only happened in the docs and
not the code.
If we're all happy with validwhen as the replacement, we should get
rid of the requiredif code, IMO. I'm not sure we need to go through
the process of deprecating the source for another release before we do
that.
--
Martin Cooper
> Whatever it is, we should at least be consistent about it.
>
> Don
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org