You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rafael Weingärtner <ra...@gmail.com> on 2015/12/20 22:19:03 UTC
Protocol to add scripts to a newer version of ACS
Hi guys,
I am working on a PR that will require some data to be added to
“guest_os_hypervisor” table. However, there is no “*to480.sql” script yet.
How is the protocol to add those inserts that I need into the code base?
--
Rafael Weingärtner
Re: Protocol to add scripts to a newer version of ACS
Posted by Rafael Weingärtner <ra...@gmail.com>.
Thanks Remi, I will use it in a PR that I am working on.
BTW: I have read a few articles (software engineering baseline management
of database objects) and searched for some tool to help us with ACS
“schema” scripts to update the database during ACS updates. I am drafting a
model that we can use to manage scripts and improve ACs database updates. I
think that I will have it ready only after 04/01/16 (giving Christmas and
New Year’s Eve). After that I believe we can start discussing and maybe
planning some changes in our protocol to create DB scripts.
On Mon, Dec 21, 2015 at 8:14 PM, Remi Bergsma <RB...@schubergphilis.com>
wrote:
> Hi Rafael,
>
> You can now make your change in this file:
>
> https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-471to480.sql
>
> Regards,
> Remi
>
>
>
> On 21/12/15 12:05, "Rafael Weingärtner" <ra...@gmail.com>
> wrote:
>
> >Thank you guys,
> >I guess I should wait for Remi's PR.
> >
> >On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma <
> RBergsma@schubergphilis.com>
> >wrote:
> >
> >> - set new version
> >> - create sql files
> >> - construct upgrade path
> >>
> >> Need to be one PR per branch as otherwise you end up on the new version
> >> without upgrade path. We did it like this last time as well.
> >>
> >> Will send a PR per branch.
> >>
> >> Sent from my iPhone
> >>
> >> > On 21 Dec 2015, at 09:48, Daan Hoogland <da...@gmail.com>
> wrote:
> >> >
> >> > Remi, What do you mean by 'more things'? It sounds like i would like
> to
> >> see
> >> > more then one PR.
> >> >
> >> > On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <
> >> RBergsma@schubergphilis.com>
> >> > wrote:
> >> >
> >> >> More things need to change at the same time. I will try to send a PR
> for
> >> >> all of it today.
> >> >>
> >> >> Regards, Remi
> >> >>
> >> >> Sent from my iPhone
> >> >>
> >> >>> On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com>
> >> wrote:
> >> >>>
> >> >>> H Rafael, just make a PR. the 4.7.0 should serve as a proper
> example.
> >> >>>
> >> >>> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
> >> >>> rafaelweingartner@gmail.com> wrote:
> >> >>>
> >> >>>> Hi guys,
> >> >>>>
> >> >>>> I am working on a PR that will require some data to be added to
> >> >>>> “guest_os_hypervisor” table. However, there is no “*to480.sql”
> script
> >> >> yet.
> >> >>>> How is the protocol to add those inserts that I need into the code
> >> base?
> >> >>>>
> >> >>>>
> >> >>>> --
> >> >>>> Rafael Weingärtner
> >> >>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>> Daan
> >> >
> >> >
> >> >
> >> > --
> >> > Daan
> >>
> >
> >
> >
> >--
> >Rafael Weingärtner
>
--
Rafael Weingärtner
Re: Protocol to add scripts to a newer version of ACS
Posted by Remi Bergsma <RB...@schubergphilis.com>.
Hi Rafael,
You can now make your change in this file:
https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-471to480.sql
Regards,
Remi
On 21/12/15 12:05, "Rafael Weingärtner" <ra...@gmail.com> wrote:
>Thank you guys,
>I guess I should wait for Remi's PR.
>
>On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma <RB...@schubergphilis.com>
>wrote:
>
>> - set new version
>> - create sql files
>> - construct upgrade path
>>
>> Need to be one PR per branch as otherwise you end up on the new version
>> without upgrade path. We did it like this last time as well.
>>
>> Will send a PR per branch.
>>
>> Sent from my iPhone
>>
>> > On 21 Dec 2015, at 09:48, Daan Hoogland <da...@gmail.com> wrote:
>> >
>> > Remi, What do you mean by 'more things'? It sounds like i would like to
>> see
>> > more then one PR.
>> >
>> > On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <
>> RBergsma@schubergphilis.com>
>> > wrote:
>> >
>> >> More things need to change at the same time. I will try to send a PR for
>> >> all of it today.
>> >>
>> >> Regards, Remi
>> >>
>> >> Sent from my iPhone
>> >>
>> >>> On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com>
>> wrote:
>> >>>
>> >>> H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
>> >>>
>> >>> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
>> >>> rafaelweingartner@gmail.com> wrote:
>> >>>
>> >>>> Hi guys,
>> >>>>
>> >>>> I am working on a PR that will require some data to be added to
>> >>>> “guest_os_hypervisor” table. However, there is no “*to480.sql” script
>> >> yet.
>> >>>> How is the protocol to add those inserts that I need into the code
>> base?
>> >>>>
>> >>>>
>> >>>> --
>> >>>> Rafael Weingärtner
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Daan
>> >
>> >
>> >
>> > --
>> > Daan
>>
>
>
>
>--
>Rafael Weingärtner
Re: Protocol to add scripts to a newer version of ACS
Posted by Sebastien Goasguen <ru...@gmail.com>.
> On Dec 21, 2015, at 1:24 PM, Remi Bergsma <RB...@schubergphilis.com> wrote:
>
> Unfortunately the mirror to Github is broken. Pushed 4.7 branch hours ago but it doesn’t show up. Can only create PR if it arrives.
>
>
confirmed, the mirror is also delayed for the website.
>
>
>
>
> On 21/12/15 12:05, "Rafael Weingärtner" <ra...@gmail.com> wrote:
>
>> Thank you guys,
>> I guess I should wait for Remi's PR.
>>
>> On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma <RB...@schubergphilis.com>
>> wrote:
>>
>>> - set new version
>>> - create sql files
>>> - construct upgrade path
>>>
>>> Need to be one PR per branch as otherwise you end up on the new version
>>> without upgrade path. We did it like this last time as well.
>>>
>>> Will send a PR per branch.
>>>
>>> Sent from my iPhone
>>>
>>>> On 21 Dec 2015, at 09:48, Daan Hoogland <da...@gmail.com> wrote:
>>>>
>>>> Remi, What do you mean by 'more things'? It sounds like i would like to
>>> see
>>>> more then one PR.
>>>>
>>>> On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <
>>> RBergsma@schubergphilis.com>
>>>> wrote:
>>>>
>>>>> More things need to change at the same time. I will try to send a PR for
>>>>> all of it today.
>>>>>
>>>>> Regards, Remi
>>>>>
>>>>> Sent from my iPhone
>>>>>
>>>>>> On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com>
>>> wrote:
>>>>>>
>>>>>> H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
>>>>>>
>>>>>> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
>>>>>> rafaelweingartner@gmail.com> wrote:
>>>>>>
>>>>>>> Hi guys,
>>>>>>>
>>>>>>> I am working on a PR that will require some data to be added to
>>>>>>> “guest_os_hypervisor” table. However, there is no “*to480.sql” script
>>>>> yet.
>>>>>>> How is the protocol to add those inserts that I need into the code
>>> base?
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Rafael Weingärtner
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Daan
>>>>
>>>>
>>>>
>>>> --
>>>> Daan
>>>
>>
>>
>>
>> --
>> Rafael Weingärtner
Re: Protocol to add scripts to a newer version of ACS
Posted by Remi Bergsma <RB...@schubergphilis.com>.
Unfortunately the mirror to Github is broken. Pushed 4.7 branch hours ago but it doesn’t show up. Can only create PR if it arrives.
On 21/12/15 12:05, "Rafael Weingärtner" <ra...@gmail.com> wrote:
>Thank you guys,
>I guess I should wait for Remi's PR.
>
>On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma <RB...@schubergphilis.com>
>wrote:
>
>> - set new version
>> - create sql files
>> - construct upgrade path
>>
>> Need to be one PR per branch as otherwise you end up on the new version
>> without upgrade path. We did it like this last time as well.
>>
>> Will send a PR per branch.
>>
>> Sent from my iPhone
>>
>> > On 21 Dec 2015, at 09:48, Daan Hoogland <da...@gmail.com> wrote:
>> >
>> > Remi, What do you mean by 'more things'? It sounds like i would like to
>> see
>> > more then one PR.
>> >
>> > On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <
>> RBergsma@schubergphilis.com>
>> > wrote:
>> >
>> >> More things need to change at the same time. I will try to send a PR for
>> >> all of it today.
>> >>
>> >> Regards, Remi
>> >>
>> >> Sent from my iPhone
>> >>
>> >>> On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com>
>> wrote:
>> >>>
>> >>> H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
>> >>>
>> >>> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
>> >>> rafaelweingartner@gmail.com> wrote:
>> >>>
>> >>>> Hi guys,
>> >>>>
>> >>>> I am working on a PR that will require some data to be added to
>> >>>> “guest_os_hypervisor” table. However, there is no “*to480.sql” script
>> >> yet.
>> >>>> How is the protocol to add those inserts that I need into the code
>> base?
>> >>>>
>> >>>>
>> >>>> --
>> >>>> Rafael Weingärtner
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Daan
>> >
>> >
>> >
>> > --
>> > Daan
>>
>
>
>
>--
>Rafael Weingärtner
Re: Protocol to add scripts to a newer version of ACS
Posted by Rafael Weingärtner <ra...@gmail.com>.
Thank you guys,
I guess I should wait for Remi's PR.
On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma <RB...@schubergphilis.com>
wrote:
> - set new version
> - create sql files
> - construct upgrade path
>
> Need to be one PR per branch as otherwise you end up on the new version
> without upgrade path. We did it like this last time as well.
>
> Will send a PR per branch.
>
> Sent from my iPhone
>
> > On 21 Dec 2015, at 09:48, Daan Hoogland <da...@gmail.com> wrote:
> >
> > Remi, What do you mean by 'more things'? It sounds like i would like to
> see
> > more then one PR.
> >
> > On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <
> RBergsma@schubergphilis.com>
> > wrote:
> >
> >> More things need to change at the same time. I will try to send a PR for
> >> all of it today.
> >>
> >> Regards, Remi
> >>
> >> Sent from my iPhone
> >>
> >>> On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com>
> wrote:
> >>>
> >>> H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
> >>>
> >>> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
> >>> rafaelweingartner@gmail.com> wrote:
> >>>
> >>>> Hi guys,
> >>>>
> >>>> I am working on a PR that will require some data to be added to
> >>>> “guest_os_hypervisor” table. However, there is no “*to480.sql” script
> >> yet.
> >>>> How is the protocol to add those inserts that I need into the code
> base?
> >>>>
> >>>>
> >>>> --
> >>>> Rafael Weingärtner
> >>>
> >>>
> >>>
> >>> --
> >>> Daan
> >
> >
> >
> > --
> > Daan
>
--
Rafael Weingärtner
Re: Protocol to add scripts to a newer version of ACS
Posted by Remi Bergsma <RB...@schubergphilis.com>.
- set new version
- create sql files
- construct upgrade path
Need to be one PR per branch as otherwise you end up on the new version without upgrade path. We did it like this last time as well.
Will send a PR per branch.
Sent from my iPhone
> On 21 Dec 2015, at 09:48, Daan Hoogland <da...@gmail.com> wrote:
>
> Remi, What do you mean by 'more things'? It sounds like i would like to see
> more then one PR.
>
> On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <RB...@schubergphilis.com>
> wrote:
>
>> More things need to change at the same time. I will try to send a PR for
>> all of it today.
>>
>> Regards, Remi
>>
>> Sent from my iPhone
>>
>>> On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com> wrote:
>>>
>>> H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
>>>
>>> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
>>> rafaelweingartner@gmail.com> wrote:
>>>
>>>> Hi guys,
>>>>
>>>> I am working on a PR that will require some data to be added to
>>>> “guest_os_hypervisor” table. However, there is no “*to480.sql” script
>> yet.
>>>> How is the protocol to add those inserts that I need into the code base?
>>>>
>>>>
>>>> --
>>>> Rafael Weingärtner
>>>
>>>
>>>
>>> --
>>> Daan
>
>
>
> --
> Daan
Re: Protocol to add scripts to a newer version of ACS
Posted by Daan Hoogland <da...@gmail.com>.
Remi, What do you mean by 'more things'? It sounds like i would like to see
more then one PR.
On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <RB...@schubergphilis.com>
wrote:
> More things need to change at the same time. I will try to send a PR for
> all of it today.
>
> Regards, Remi
>
> Sent from my iPhone
>
> > On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com> wrote:
> >
> > H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
> >
> > On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
> > rafaelweingartner@gmail.com> wrote:
> >
> >> Hi guys,
> >>
> >> I am working on a PR that will require some data to be added to
> >> “guest_os_hypervisor” table. However, there is no “*to480.sql” script
> yet.
> >> How is the protocol to add those inserts that I need into the code base?
> >>
> >>
> >> --
> >> Rafael Weingärtner
> >
> >
> >
> > --
> > Daan
>
--
Daan
Re: Protocol to add scripts to a newer version of ACS
Posted by Remi Bergsma <RB...@schubergphilis.com>.
More things need to change at the same time. I will try to send a PR for all of it today.
Regards, Remi
Sent from my iPhone
> On 21 Dec 2015, at 07:51, Daan Hoogland <da...@gmail.com> wrote:
>
> H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
>
> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
> rafaelweingartner@gmail.com> wrote:
>
>> Hi guys,
>>
>> I am working on a PR that will require some data to be added to
>> “guest_os_hypervisor” table. However, there is no “*to480.sql” script yet.
>> How is the protocol to add those inserts that I need into the code base?
>>
>>
>> --
>> Rafael Weingärtner
>
>
>
> --
> Daan
Re: Protocol to add scripts to a newer version of ACS
Posted by Daan Hoogland <da...@gmail.com>.
H Rafael, just make a PR. the 4.7.0 should serve as a proper example.
On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
rafaelweingartner@gmail.com> wrote:
> Hi guys,
>
> I am working on a PR that will require some data to be added to
> “guest_os_hypervisor” table. However, there is no “*to480.sql” script yet.
> How is the protocol to add those inserts that I need into the code base?
>
>
> --
> Rafael Weingärtner
>
--
Daan