DO NOT REPLY [Bug 18619] New: - action attribute not added to code and tld

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18619>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18619

<html:rewrite> action attribute not added to code and tld

           Summary: <html:rewrite> action attribute not added to code and
                    tld
           Product: Struts
           Version: 1.1 RC1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Custom Tags
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: dougvanhorn@yahoo.com


The RewriteTag.java file needs to be updated to reflect the changes in the
LinkTag.java file.  Specifically, the 'action' attribute on the tag is not
reflected in the struts-html.tld.

Add this to the rewrite tag in the tld:

<attribute>
<name>action</name>
<required>false</required>
<rtexprvalue>true</rtexprvalue>
</attribute>


And update the RewriteTag.java file to compute the proper url:

(In RewriteTag.java, doStartTag method)
  url = RequestUtils.computeURL(pageContext, forward, href,
                                page, params, anchor, false);

to

  url = RequestUtils.computeURL(pageContext, forward, href,
                                page, action, params, anchor, false);



It is in the LinkTag.java file:

(In LinkTag.java, calculateUrl method)
  url = RequestUtils.computeURL(pageContext, forward, href,
                                page, action, params, anchor, false);

I have only taken a brief glance at the code, but I suspect you really want to
call the 'calculateUrl' method from the RewriteTag class rather than computing
it independantly of the parent...


Hope this helps.  Thanks for the great work!


doug van horn

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org