[jira] [Commented] (THRIFT-3008) Node.js server does not fully support exception

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332258#comment-14332258 ] 

ASF GitHub Bot commented on THRIFT-3008:
----------------------------------------

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/382

    THRIFT-3008 - Node.js server does not fully support exception

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-3008

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #382
    
----
commit 0c0d51ca1dafa5f8e0004563df780a92580590f3
Author: Nobuaki Sukegawa <ns...@gmail.com>
Date:   2015-02-22T16:49:22Z

    THRIFT-3008 - Node.js server does not fully support exception

----


> Node.js server does not fully support exception
> -----------------------------------------------
>
>                 Key: THRIFT-3008
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3008
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Compiler
>            Reporter: Nobuaki Sukegawa
>
> To my understanding (based on comment in TestThrift.thrift and C++ server behavior), servers should be able to send T(Application)Exception when an error occurred in the handler.
> Node.js server supports exceptions explicitly declared with "throws", but does not support the type of exceptions stated above.
> Also, the client test (lib/nodejs/test/test_driver.js) assumes current Node.js server behavior, resulting in cross test failures against C++ and Java reference implementations.
> This patch makes compiler generate server code that can emit errors in an identical way to C++ server code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)