You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/02/18 13:46:23 UTC
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15237
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Add arm64 openjdk version for Ubuntu 18.04 in bootstrap_system.sh
Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/15237/1
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15237/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/15237/1/bin/bootstrap_system.sh@298
PS1, Line 298: SET_LD_LIBRARY_PATH='export LD_LIBRARY_PATH=/usr/lib/aarch64-linux-gnu/${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}'
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/15237/1/bin/bootstrap_system.sh@300
PS1, Line 300: SET_LD_LIBRARY_PATH='export LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}'
line too long (112 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Feb 2020 13:47:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 5:
Thanks for your contribution!
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 23:36:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Add arm64 openjdk version for Ubuntu 18.04 in bootstrap_system.sh
Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Reviewed-on: http://gerrit.cloudera.org:8080/15237
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5252/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Feb 2020 14:30:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 1:
(2 comments)
I think this looks good, we need some minor cleanup before merging
http://gerrit.cloudera.org:8080/#/c/15237/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/15237/1/bin/bootstrap_system.sh@220
PS1, Line 220: `uname -p`
Can you use $(uname -p) to be consistent with the rest of the script?
http://gerrit.cloudera.org:8080/#/c/15237/1/bin/bootstrap_system.sh@297
PS1, Line 297: if [[ $ARCH_NAME == 'aarch64' ]]; then
I think you can simplify this to:
SET_LD_LIBRARY_PATH='export LD_LIBRARY_PATH=/usr/lib/${ARCH_NAME}-linux-gnu/${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}'
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Feb 2020 18:32:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 22:13:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15237/4/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/15237/4/bin/bootstrap_system.sh@297
PS4, Line 297: SET_LD_LIBRARY_PATH="export LD_LIBRARY_PATH=/usr/lib/${ARCH_NAME}-linux-gnu/${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
line too long (116 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 02:07:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5362/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 09:18:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5362/
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 17:49:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Add arm64 openjdk version for Ubuntu 18.04 in bootstrap_system.sh
Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
---
M bin/bootstrap_system.sh
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/15237/4
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5360/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 02:09:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 02:09:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5360/
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 07:02:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5265/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 03:07:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15237 )
Change subject: IMPALA-9396 Add arm64 openjdk version for Ubuntu 18.04
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5367/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7572439cef8f53499c3b20a09269613feea2cf
Gerrit-Change-Number: 15237
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 17:52:17 +0000
Gerrit-HasComments: No