You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2010/07/27 09:59:54 UTC
Re: svn commit: r965395 - /harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/unix/makefile
In message <20...@eris.apache.org>, regisxu@apache.org
writes:
>
> Author: regisxu
> Date: Mon Jul 19 09:17:09 2010
> New Revision: 965395
>
> URL: http://svn.apache.org/viewvc?rev=965395&view=rev
> Log:
> samsa also need to link a2e module on z/OS.
>
> Modified:
> harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/
> unix/makefile
>
> Modified: harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/
> samsa/unix/makefile
> URL: http://svn.apache.org/viewvc/harmony/enhanced/java/trunk/jdktools/module
> s/samsa/src/main/native/samsa/unix/makefile?rev=965395&r1=965394&r2=965395&vi
> ew=diff
> =============================================================================
> =
> --- harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/
> unix/makefile (original)
> +++ harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/
> unix/makefile Mon Jul 19 09:17:09 2010
> @@ -23,6 +23,4 @@ BUILDFILES = ../samsa.o
>
> EXENAME = $(LIBPATH)samsa
>
> -MDLLIBFILES =
> -
> include $(HY_HDK)/build/make/rules.mk
Regis,
This breaks the samsa launcher so that although:
hdk/jdk/jre/bin/java -version
works, the jdk tools samsa 'java':
hdk/jdk/bin/java -version
do not - as it is now linked against libhythr which it doesn't need and
can't find.
I've reverted this in r979569.
Please use a z/OS specific ifdef to add just the library that z/OS needs
to link against - just a2e I assume not all of the defaults.
Regards,
Mark.
Re: svn commit: r965395 - /harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/unix/makefile
Posted by regis xu <xu...@gmail.com>.
On Tue, Jul 27, 2010 at 3:59 PM, Mark Hindess
<ma...@googlemail.com>wrote:
>
> In message <20...@eris.apache.org>,
> regisxu@apache.org
> writes:
> >
> > Author: regisxu
> > Date: Mon Jul 19 09:17:09 2010
> > New Revision: 965395
> >
> > URL: http://svn.apache.org/viewvc?rev=965395&view=rev
> > Log:
> > samsa also need to link a2e module on z/OS.
> >
> > Modified:
> >
> harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/
> > unix/makefile
> >
> > Modified:
> harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/
> > samsa/unix/makefile
> > URL:
> http://svn.apache.org/viewvc/harmony/enhanced/java/trunk/jdktools/module
> >
> s/samsa/src/main/native/samsa/unix/makefile?rev=965395&r1=965394&r2=965395&vi
> > ew=diff
> >
> =============================================================================
> > =
> > ---
> harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/
> > unix/makefile (original)
> > +++
> harmony/enhanced/java/trunk/jdktools/modules/samsa/src/main/native/samsa/
> > unix/makefile Mon Jul 19 09:17:09 2010
> > @@ -23,6 +23,4 @@ BUILDFILES = ../samsa.o
> >
> > EXENAME = $(LIBPATH)samsa
> >
> > -MDLLIBFILES =
> > -
> > include $(HY_HDK)/build/make/rules.mk
>
>
> Regis,
>
> This breaks the samsa launcher so that although:
>
> hdk/jdk/jre/bin/java -version
>
> works, the jdk tools samsa 'java':
>
> hdk/jdk/bin/java -version
>
> do not - as it is now linked against libhythr which it doesn't need and
> can't find.
>
> I've reverted this in r979569.
>
> Please use a z/OS specific ifdef to add just the library that z/OS needs
> to link against - just a2e I assume not all of the defaults.
>
> Regards,
> Mark.
>
>
>
Thanks Mark, new fix was applied at r979615.