You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2025/05/14 00:51:00 UTC

[jira] [Commented] (HBASE-29288) Avoid adding new blocks during prefetch if usage is greater than accept factor

    [ https://issues.apache.org/jira/browse/HBASE-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951300#comment-17951300 ] 

Hudson commented on HBASE-29288:
--------------------------------

Results for branch master
	[build #1294 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1294/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1294/General_20Nightly_20Build_20Report/]










(/) {color:green}+1 jdk17 hadoop 3.3.5 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1294/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.3.6 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1294/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop 3.4.0 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1294/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]






> Avoid adding new blocks during prefetch if usage is greater than accept factor
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-29288
>                 URL: https://issues.apache.org/jira/browse/HBASE-29288
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-beta-1, 4.0.0-alpha-1
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.0.0, 4.0.0-alpha-1
>
>
> If cache prefetch is enabled, if cache usage reaches the configured accept factor, we'll enter a cycle of frequent blocks mass evictions until the prefetch completes. This is quite costly and inefficient.
> A first attempt to avoid this was proposed in HBASE-28176. However, this solution only interrupts the prefetch thread once we had already attempted to cache the current block being read, which may already trigger a mass eviction. 
> To completely avoid evictions being triggered solely by the prefetch, we should check the impact of adding the current block to the cache before we actual write it, and avoid the mass evictions. This check should be done only when caching from prefetch threads, normal client reads and hfile writes should still cache blocks, regardless.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)