[GitHub] szha commented on a change in pull request #11127: add import_ for SymbolBlock

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #11127: add import_ for SymbolBlock
URL: https://github.com/apache/incubator-mxnet/pull/11127#discussion_r193874228
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -317,8 +317,19 @@ def save_params(self, filename):
         arg_dict = {key : val._reduce() for key, val in params.items()}
         ndarray.save(filename, arg_dict)
 
-    def load_params(self, filename, ctx=None, allow_missing=False,
-                    ignore_extra=False):
+    def save_params(self, filename):
+        """[Deprecated] Please use save_parameters.
+
+        Save parameters to file.
+
+        filename : str
+            Path to file.
+        """
+        warnings.warn("save_params is deprecated. Please use save_parameters.")
+        self.collect_params().save(filename, strip_prefix=self.prefix)
 
 Review comment:
   let's not make this change to the save_params.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services