You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2007/11/02 02:06:50 UTC

[jira] Created: (PIG-8) Use binary comparison in data types

Use binary comparison in data types
-----------------------------------

                 Key: PIG-8
                 URL: https://issues.apache.org/jira/browse/PIG-8
             Project: Pig
          Issue Type: Improvement
          Components: impl
            Reporter: Olga Natkovich
            Assignee: Olga Natkovich


Currently, each data type in Pig has compareTo function as the means to compare objects during maps side sort. This is very inefficient since 2 objects need to be created for each comparison. Using binary comparison should speed things up significantly(2-3x) for most queries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-8) Use binary comparison in data types

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543234 ] 

Alan Gates commented on PIG-8:
------------------------------

+1

Reviewed the code, it looks fine.

> Use binary comparison in data types
> -----------------------------------
>
>                 Key: PIG-8
>                 URL: https://issues.apache.org/jira/browse/PIG-8
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>         Attachments: BinaryCompare.patch
>
>
> Currently, each data type in Pig has compareTo function as the means to compare objects during maps side sort. This is very inefficient since 2 objects need to be created for each comparison. Using binary comparison should speed things up significantly(2-3x) for most queries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIG-8) Use binary comparison in data types

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich resolved PIG-8.
------------------------------

    Resolution: Fixed

Patch commited

> Use binary comparison in data types
> -----------------------------------
>
>                 Key: PIG-8
>                 URL: https://issues.apache.org/jira/browse/PIG-8
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>         Attachments: BinaryCompare.patch
>
>
> Currently, each data type in Pig has compareTo function as the means to compare objects during maps side sort. This is very inefficient since 2 objects need to be created for each comparison. Using binary comparison should speed things up significantly(2-3x) for most queries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-8) Use binary comparison in data types

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-8:
-----------------------------

    Attachment: BinaryCompare.patch

Please, see attached changes to fix this issue. All unit tests passed and 80 end-to-end tests passed as well. I am seeing 40% performance improvement on the group by test.

> Use binary comparison in data types
> -----------------------------------
>
>                 Key: PIG-8
>                 URL: https://issues.apache.org/jira/browse/PIG-8
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>         Attachments: BinaryCompare.patch
>
>
> Currently, each data type in Pig has compareTo function as the means to compare objects during maps side sort. This is very inefficient since 2 objects need to be created for each comparison. Using binary comparison should speed things up significantly(2-3x) for most queries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.