You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2010/10/21 21:54:15 UTC
[jira] Created: (LUCENE-2718) separate java code from .jj file
separate java code from .jj file
--------------------------------
Key: LUCENE-2718
URL: https://issues.apache.org/jira/browse/LUCENE-2718
Project: Lucene - Java
Issue Type: Improvement
Components: QueryParser
Reporter: Yonik Seeley
Priority: Minor
It would make development easier to move most of the java code out from the .jj file and into a real java file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2718) separate java code from .jj file
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved LUCENE-2718.
----------------------------------
Resolution: Fixed
Fix Version/s: 4.0
> separate java code from .jj file
> --------------------------------
>
> Key: LUCENE-2718
> URL: https://issues.apache.org/jira/browse/LUCENE-2718
> Project: Lucene - Java
> Issue Type: Improvement
> Components: QueryParser
> Reporter: Yonik Seeley
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2718.patch, LUCENE-2718.patch
>
>
> It would make development easier to move most of the java code out from the .jj file and into a real java file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2718) separate java code from .jj file
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923610#action_12923610 ]
Robert Muir commented on LUCENE-2718:
-------------------------------------
just taking a quick glance, I am really for the change.
I can't stand not having syntax/error highlighting in my IDE, always
having to regenerate the .jj file with 'ant javacc' only to find i made a stupid typo.
> separate java code from .jj file
> --------------------------------
>
> Key: LUCENE-2718
> URL: https://issues.apache.org/jira/browse/LUCENE-2718
> Project: Lucene - Java
> Issue Type: Improvement
> Components: QueryParser
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: LUCENE-2718.patch
>
>
> It would make development easier to move most of the java code out from the .jj file and into a real java file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2718) separate java code from .jj file
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated LUCENE-2718:
---------------------------------
Attachment: LUCENE-2718.patch
Here's an update that pulls out more (some of the larger code blocks that were embedded in the middle of the grammar).
I'll probably commit tomorrow if no one things it's a bad idea.
> separate java code from .jj file
> --------------------------------
>
> Key: LUCENE-2718
> URL: https://issues.apache.org/jira/browse/LUCENE-2718
> Project: Lucene - Java
> Issue Type: Improvement
> Components: QueryParser
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: LUCENE-2718.patch, LUCENE-2718.patch
>
>
> It would make development easier to move most of the java code out from the .jj file and into a real java file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2718) separate java code from .jj file
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated LUCENE-2718:
---------------------------------
Attachment: LUCENE-2718.patch
Here's a first cut at this, pulling out most stuff in QueryParser into QueryParserBase.
This would make it easier to do refactorings and changes in Java (instead of a .JJ file which isn't well supported in IDEs), and allows more changes w/o having to recompile the grammar.
Thoughts?
> separate java code from .jj file
> --------------------------------
>
> Key: LUCENE-2718
> URL: https://issues.apache.org/jira/browse/LUCENE-2718
> Project: Lucene - Java
> Issue Type: Improvement
> Components: QueryParser
> Reporter: Yonik Seeley
> Priority: Minor
> Attachments: LUCENE-2718.patch
>
>
> It would make development easier to move most of the java code out from the .jj file and into a real java file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org