You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/07 21:13:21 UTC
[jira] [Commented] (FLINK-4595) Close FileOutputStream in
ParameterTool
[ https://issues.apache.org/jira/browse/FLINK-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471823#comment-15471823 ]
ASF GitHub Bot commented on FLINK-4595:
---------------------------------------
GitHub user apivovarov opened a pull request:
https://github.com/apache/flink/pull/2478
[FLINK-4595] Close FileOutputStream in ParameterTool
https://issues.apache.org/jira/browse/FLINK-4595
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apivovarov/flink FLINK-4595
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2478.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2478
----
commit 46f68d5fc621324368ad31fbba52bdf13abfae48
Author: Alexander Pivovarov <ap...@gmail.com>
Date: 2016-09-07T21:11:06Z
[FLINK-4595] Close FileOutputStream in ParameterTool
----
> Close FileOutputStream in ParameterTool
> ---------------------------------------
>
> Key: FLINK-4595
> URL: https://issues.apache.org/jira/browse/FLINK-4595
> Project: Flink
> Issue Type: Bug
> Components: Java API
> Affects Versions: 1.1.2
> Reporter: Alexander Pivovarov
> Priority: Trivial
>
> ParameterTool and ParameterToolTest do not close FileOutputStream
> {code}
> defaultProps.store(new FileOutputStream(file), "Default file created by Flink's ParameterUtil.createPropertiesFile()");
> {code}
> {code}
> props.store(new FileOutputStream(propertiesFile), "Test properties");
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)