You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Cccccczj (via GitHub)" <gi...@apache.org> on 2024/10/11 08:53:33 UTC
[PR] move "#define STRINGIFY(x)" to nuttx/macro.h [nuttx]
Cccccczj opened a new pull request, #14110:
URL: https://github.com/apache/nuttx/pull/14110
"#define STRINGIFY(x)" conflicts with https://github.com/mborgerding/kissfft define
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] move "#define STRINGIFY(x)" to nuttx/macro.h [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14110:
URL: https://github.com/apache/nuttx/pull/14110#issuecomment-2406952646
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
__Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
**No, the provided information does not meet the NuttX PR requirements.**
The description only provides a summary of the issue (a naming conflict) and lacks crucial details:
* **Missing Context:** What change are you proposing? Simply stating a conflict isn't helpful.
* **No Proposed Solution:** How do you plan to resolve the naming conflict? Renaming, namespacing?
* **Impact Analysis:** You need to analyze the impact on users, build process, hardware, documentation, security, compatibility, etc.
* **Testing Details:** What specific build hosts and targets did you test on? Provide details beyond just "local setup." Show actual testing logs before and after your proposed change.
**To meet NuttX PR requirements, you need to:**
1. **Describe your solution:** How are you resolving the `#define STRINGIFY(x)` conflict?
2. **Provide a detailed impact analysis:** Address all the points mentioned in the "Impact" section.
3. **Include thorough testing information:** Specify your build host and target environments, and include actual testing logs from before and after your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] move "#define STRINGIFY(x)" to nuttx/macro.h [nuttx]
Posted by "Cccccczj (via GitHub)" <gi...@apache.org>.
Cccccczj closed pull request #14110: move "#define STRINGIFY(x)" to nuttx/macro.h
URL: https://github.com/apache/nuttx/pull/14110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org