You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "jorgebay (GitHub)" <gi...@apache.org> on 2018/10/23 10:32:08 UTC

[GitHub] [tinkerpop] jorgebay opened pull request #966: TINKERPOP-2070: Introduce Connection and ResultSet abstractions

https://issues.apache.org/jira/browse/TINKERPOP-2070

Extract `Connection` implementation out of the `DriverRemoteConnection`.

The `DriverRemoteConnection` now uses a `Client` instance, a `Client` instance may contain one or more `Connection` instances, similar to the Python and .NET glv.

Introduce `ResultSet` that is aligned to other GLVs: 
- `Client` and `Connection` `submit()` methods return a `ResultSet` instance
- `DriverRemoteConnection` submissions returns an instance of `RemoteTraversal`.

This is a large-ish refactor but it doesn't represent a breaking change for the user.

Additionally, I've identified an issue when we introduced script submission support in gremlin-javascript (my bad!): We exposed a property named `traversers` (see previous code examples). I've maintained that property and marked it as deprecated, to be removed in 3.4, and updated all code examples to stop referencing to it.

[ Full content available at: https://github.com/apache/tinkerpop/pull/966 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #966: TINKERPOP-2070: Introduce Connection and ResultSet abstractions

Posted by "spmallette (GitHub)" <gi...@apache.org>.

we usually don't edit past upgrade notes - they are static and bound to that version, but i think i see what you're trying to do here, i.e. hide away `traversers`....i guess that's ok

[ Full content available at: https://github.com/apache/tinkerpop/pull/966 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on pull request #966: TINKERPOP-2070: Introduce Connection and ResultSet abstractions

Posted by "jorgebay (GitHub)" <gi...@apache.org>.

Yes, the idea is to hide a deprecated property :)

[ Full content available at: https://github.com/apache/tinkerpop/pull/966 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay closed pull request #966: TINKERPOP-2070: Introduce Connection and ResultSet abstractions

Posted by "jorgebay (GitHub)" <gi...@apache.org>.

[ pull request closed by jorgebay ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/966 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #966: TINKERPOP-2070: Introduce Connection and ResultSet abstractions

Posted by "spmallette (GitHub)" <gi...@apache.org>.

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/966 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #966: TINKERPOP-2070: Introduce Connection and ResultSet abstractions

Posted by "jorgebay (GitHub)" <gi...@apache.org>.

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/966 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org