You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "rdhabalia (via GitHub)" <gi...@apache.org> on 2023/03/02 21:04:07 UTC

[GitHub] [pulsar] rdhabalia opened a new pull request, #19696: Fix Pulsar admin tool is ignoring tls-trust-cert path arg

rdhabalia opened a new pull request, #19696:
URL: https://github.com/apache/pulsar/pull/19696

   ### Motivation
   
   Right now, PulsarAdmin Tool ignores CLI provided arg for tlsTrustStoreCertPath. This PR fixes and validate it with the testcase.
   
   ### Modifications
   
   CLI updates trust-cert path if it's provided in CLI arg.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1452945205

   > > LGTM. @rdhabalia - did you check for any other missed params?
   > 
   > I can fix other parameters.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1625059590

   Branch 2.10 does not contain the implementation of `PulsarAdminSupplier`, so I remove the release/2.10.5 label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1610271880

   As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1452945121

   > LGTM. @rdhabalia - did you check for any other missed params?
   
   I can fix other parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rdhabalia commented on a diff in pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "rdhabalia (via GitHub)" <gi...@apache.org>.
rdhabalia commented on code in PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#discussion_r1123838388


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminSupplier.java:
##########
@@ -103,6 +103,9 @@ private static void applyRootParamsToAdminBuilder(PulsarAdminBuilder adminBuilde
         if (isNotBlank(rootParams.tlsProvider)) {
             adminBuilder.sslProvider(rootParams.tlsProvider);
         }
+        if (isNotBlank(rootParams.tlsTrustCertsFilePath)) {
+            adminBuilder.tlsTrustCertsFilePath(rootParams.tlsTrustCertsFilePath);

Review Comment:
   @michaeljmarshall there are two ways to configure variables: configure in conf file or pass as arguments in CLI. right now, it only reads from `conf/client.conf` file but it ignores if user provide as a cli argument that's because it doesn't check `rootParams.tlsTrustCertsFilePath` which is parsed as CLI args.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1453206038

   The config file parameters should be the same as the flags, but I forget to add these parameters to the flag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1454669140

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #19696: Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1452543666

   @rdhabalia Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on code in PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#discussion_r1123718789


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminSupplier.java:
##########
@@ -103,6 +103,9 @@ private static void applyRootParamsToAdminBuilder(PulsarAdminBuilder adminBuilde
         if (isNotBlank(rootParams.tlsProvider)) {
             adminBuilder.sslProvider(rootParams.tlsProvider);
         }
+        if (isNotBlank(rootParams.tlsTrustCertsFilePath)) {
+            adminBuilder.tlsTrustCertsFilePath(rootParams.tlsTrustCertsFilePath);

Review Comment:
   Quickly reading the source code, it looks like we read it from the `client.conf` file here:
   
   https://github.com/apache/pulsar/blob/fb0cb1ce71a14b8109c828a8d9fcfc15b84e6a09/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java#L123
   
   I mention it in case anyone needs a workaround.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rdhabalia commented on pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "rdhabalia (via GitHub)" <gi...@apache.org>.
rdhabalia commented on PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#issuecomment-1453139634

   @nodece which parameter you are referring? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] rdhabalia merged pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

Posted by "rdhabalia (via GitHub)" <gi...@apache.org>.
rdhabalia merged PR #19696:
URL: https://github.com/apache/pulsar/pull/19696


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org