[GitHub] [airflow] potiuk commented on pull request #8595: test pulling docker iamge from github

[GitBox <gi...@apache.org>]

potiuk commented on pull request #8595:
URL: https://github.com/apache/airflow/pull/8595#issuecomment-620479743


   Hey @dimberman. Not sure what you want to achieve I am not sure if you noticed, but the images are already pulled from github. This was implemented as part of my CI optimisations : https://github.com/apache/airflow/commit/e11a838ee1e76dfac45c0f6464f18c0816ab034e 
   
   See the https://github.com/apache/airflow/blob/master/CI.rst where it is nicely described how our CI process work including image and details explanation of each job type and purpose.
   
   Those environment variables at the top of the ci.yml
   ```
     CACHE_REGISTRY: "docker.pkg.github.com"
     CACHE_IMAGE_PREFIX: ${{ github.repository }}	  CACHE_IMAGE_PREFIX: ${{ github.repository }}
     CACHE_REGISTRY_USERNAME: ${{ github.actor }}	  CACHE_REGISTRY_USERNAME: ${{ github.actor }}
     CACHE_REGISTRY_PASSWORD: ${{ secrets.GITHUB_TOKEN }}	  CACHE_REGISTRY_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
   ```
   
   And they are used as a first instance to pull images from Github registry. Additionally, there are the two steps:  push-ci-images-to-github-cache,   push-prod-images-to-github-cache the images are pushed to github - but it only happens when all the tests are successful after PR is merged to master - which keeps the cache updated - this way we make sure tha the github registry images are "fresh". 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org