[GitHub] spark issue #16457: [SPARK-19057][ML] Instances' weight must be non-negative

[srowen <gi...@git.apache.org>]

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/16457
  
    The doc fixes look unrelated; let's exclude those?
    There are many weight fields/args in .ml that should probably also be checked -- would you please skim them and see if there are other obviously points where the caller could supply a weight that's negative? I agree that there is almost never a good reason to supply them, though in some particular cases you can make out a coherent meaning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org