You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-dev@incubator.apache.org by Ja...@rzf.fin-nrw.de on 2007/07/10 07:03:55 UTC

AW: svn commit: r554661 - in /incubator/ivy/core/trunk: ./ doc/ doc/use/ src/example/chained-resolvers/ src/example/chained-resolvers/chainedresolvers-project/ src/example/configurations/jdbc-example/ src/example/configurations/multi-projects/filter-frame

>Author: xavier
>Date: Mon Jul  9 07:32:31 2007
>New Revision: 554661
>
>URL: http://svn.apache.org/viewvc?view=rev&rev=554661
>Log:
>- NEW: Add cleancache task (IVY-565)
>- FIX: Ant target "clean" on Ivy multi-project tutorial points to wrong
cache directory. (IVY-548)


While there is a good commit comment I think it would be better to have
two separate commits in 
case you want to revert one... But just my 2ct.
>incubator/ivy/core/trunk/src/example/multi-project/build.xml (original)
> 	<!-- here is the version of ivy we will use. change this
property to try a newer 
>          version if you want -->
>-	<property name="ivy.jar.dir" value="${user.home}/.ivy/jars" />
>+	<property name="ivy.jar.dir" value="${user.home}/.ivy2/jars" />


Do you want to change "globally" to ~/.ivy2?



>Added: 
>incubator/ivy/core/trunk/src/java/org/apache/ivy/ant/IvyCleanCache.java

>+ *  Using the delete task gives more control over what is actually
deleted (you can use include
>+ *  and exclude filters), but requires a settings to be loaded before,
while this task
>+ *  ensures the settings is loaded.


We could also delegate include/exclude pattern ...


>+ */
>+public class IvyCleanCache extends IvyTask {
>+
>+    public void doExecute() throws BuildException {
>+        Delete delete = new Delete();


You should invoke >>  delete.bindToOwner(this);  << (on Ant 1.7)


    public final void bindToOwner(Task owner) {
        setProject(owner.getProject());
        setOwningTarget(owner.getOwningTarget());
        setTaskName(owner.getTaskName());
        setDescription(owner.getDescription());
        setLocation(owner.getLocation());
        setTaskType(owner.getTaskType());
    }




Jan