You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by ravicodder <gi...@git.apache.org> on 2016/02/04 07:19:45 UTC
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/689
Add new selenium test case to test clear output button
##What is this PR for?
Add a new test case for testing the clear output button.
Clear output button clears the output on the paragraph
##What type of PR is it?
Test
##Is there a relevant Jira issue?
NA
##How should this be tested?
On OSX, you'll need firefox 42.0 installed, then you can run with
PATH=~/Applications/Firefox.app/Contents/MacOS/:$PATH CI="" \
mvn -Dtest=org.apache.zeppelin.ParagraphActionsIT -Denforcer.skip=true \
test -pl zeppelin-server
##Questions:
Does the licenses files need update?NO
Is there breaking changes for older versions?NO
Does this needs documentation?NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravicodder/incubator-zeppelin testClearOutputButton
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #689
----
commit f4a08834e1f3581095ec54f7d490681ff3c6233d
Author: Ravi Ranjan <ra...@gmail.com>
Date: 2016-02-03T14:41:37Z
Add new selenium test case for clear output button of paragraph
commit a8be230ab7b0c5079c813aa74a8176ca35119f3d
Author: Ravi Ranjan <ra...@gmail.com>
Date: 2016-02-04T06:09:19Z
add modified checkthat message
commit ccecb6cd58db2fd63a885bc6372417608ae0e69d
Author: Ravi Ranjan <ra...@gmail.com>
Date: 2016-02-04T06:15:42Z
Add new selenium test case to test clear output button
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-188546460
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186858173
@prabhjyotsingh @corneadoug
Changes has been done, Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187600870
@corneadoug Corrected bad rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-186759123
This should catch all Exception not just ElementNotVisibleException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-185311026
CI is now failing on:
```
Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 25.538 sec <<< FAILURE! - in org.apache.zeppelin.integration.ParagraphActionsIT
testClearOutputButton(org.apache.zeppelin.integration.ParagraphActionsIT) Time elapsed: 5.039 sec <<< ERROR!
org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@ng-controller=\"ParagraphCtrl\"][1]//div[contains(@class,'text ng-scope')]"}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187291948
Question, why is that test deleting: `testCreateNewButton`? Is that a result of the rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187133115
@prabhjyotsingh used handleException, please have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add new selenium test case to tes...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-185040701
Tested, CI green, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---