[GitHub] [hive] risdenk commented on a change in pull request #1411: Hive24048

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #1411:
URL: https://github.com/apache/hive/pull/1411#discussion_r477404084



##########
File path: pom.xml
##########
@@ -659,9 +659,14 @@
         <artifactId>jackson-dataformat-smile</artifactId>
         <version>${jackson.version}</version>
       </dependency>
+      <dependency>
+        <groupId>com.fasterxml.jackson.dataformat</groupId>
+        <artifactId>jackson-dataformat-yaml</artifactId>
+        <version>${jackson.version}</version>
+      </dependency>
       <dependency>
         <groupId>com.fasterxml.jackson.jaxrs</groupId>
-        <artifactId>jackson-jaxrs-json-provider</artifactId>
+        <artifactId>jackson-jaxrs-base</artifactId>

Review comment:
       Instead of calling out all of the Jackson dependencies separately in the top level pom, there is a Jackson BOM that should help with this.
   
   https://github.com/FasterXML/jackson-bom
   
   specifically add to the dependency management section in the top level pom:
   
   ```
           <dependency>
               <groupId>com.fasterxml.jackson</groupId>
               <artifactId>jackson-bom</artifactId>
               <version>${jackson.version}</version>
               <scope>import</scope>
               <type>pom</type>
           </dependency>  
   ```
   
   This will ensure all the Jackson dependencies are the right version. This should avoid even having to declare all the individual jackson dependencies in the top level pom w/ versions. 
   
   PS - you can do the same with Spring and Netty. There are a few other projects that produce BOM artifacts to specifically help with this .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org