You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/01 16:42:03 UTC

[GitHub] [superset] geido opened a new pull request #13916: test: Tests audit for the Dashboard FilterBar

geido opened a new pull request #13916:
URL: https://github.com/apache/superset/pull/13916


   ### SUMMARY
   Adds and enhances tests for the Dashboard FilterBar (nativeFilters.)
   
   ### TEST PLAN
   All tests should pass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-814505082


   @pkdotson Ephemeral environment creation is currently limited to committers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] yardz commented on a change in pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13916:
URL: https://github.com/apache/superset/pull/13916#discussion_r608979667



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.test.tsx
##########
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import { mockStore } from 'spec/fixtures/mockStore';
+import { Provider } from 'react-redux';
+import FilterSets, { FilterSetsProps } from './FilterSets';
+
+const mockedProps = {
+  disabled: false,
+  isFilterSetChanged: false,
+  dataMaskSelected: {
+    'filter-id': {
+      currentState: {
+        value: [],
+      },
+    },
+  },
+  onEditFilterSet: jest.fn(),
+  onFilterSelectionChange: jest.fn(),
+};
+
+const setup = (props: FilterSetsProps) => (
+  <Provider store={mockStore}>
+    <FilterSets {...props} />
+  </Provider>
+);
+
+test('should render', () => {
+  const { container } = render(setup(mockedProps));
+  expect(container).toBeInTheDocument();
+  screen.debug();

Review comment:
       Forgot the debug here :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (f676e7b) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.80%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   - Coverage   79.21%   78.41%   -0.81%     
   ==========================================
     Files         936      940       +4     
     Lines       47408    47593     +185     
     Branches     5940     5978      +38     
   ==========================================
   - Hits        37554    37318     -236     
   - Misses       9727    10128     +401     
   - Partials      127      147      +20     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.68% <ø> (-0.37%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `34.00% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `43.47% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `28.20% <ø> (-3.23%)` | :arrow_down: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `47.61% <ø> (ø)` | |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `4.54% <ø> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `80.95% <ø> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `91.80% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [50 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [f06d534...f676e7b](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (c7bd361) into [master](https://codecov.io/gh/apache/superset/commit/2c96c5b3419de54c898c773bff00591e0c623fc2?el=desc) (2c96c5b) will **decrease** coverage by `0.57%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head c7bd361 differs from pull request most recent head aa400ec. Consider uploading reports for the commit aa400ec to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   - Coverage   79.30%   78.72%   -0.58%     
   ==========================================
     Files         938      946       +8     
     Lines       47523    47966     +443     
     Branches     5940     6092     +152     
   ==========================================
   + Hits        37687    37763      +76     
   - Misses       9710    10076     +366     
   - Partials      126      127       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.08% <ø> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `41.02% <ø> (ø)` | |
   | [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `34.00% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `43.47% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `28.20% <ø> (-3.23%)` | :arrow_down: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `47.61% <ø> (ø)` | |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `4.54% <ø> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `80.95% <ø> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `91.80% <ø> (ø)` | |
   | ... and [53 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [9e03b6d...aa400ec](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on a change in pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13916:
URL: https://github.com/apache/superset/pull/13916#discussion_r606182196



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSetUnit.test.tsx
##########
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import { mockStore } from 'spec/fixtures/mockStore';
+import { Provider } from 'react-redux';
+import userEvent from '@testing-library/user-event';
+import FilterSetUnit, { FilterSetUnitProps } from './FilterSetUnit';
+
+const mockedProps = {
+  editMode: true,
+  setFilterSetName: jest.fn(),
+  onDelete: jest.fn(),
+  onEdit: jest.fn(),
+  onRebuild: jest.fn(),
+};
+
+function openDropdown() {
+  const dropdownIcon = screen.getByRole('img', { name: 'ellipsis' });
+  userEvent.click(dropdownIcon);
+}
+
+const setup = (props: FilterSetUnitProps) => (
+  <Provider store={mockStore}>
+    <FilterSetUnit {...props} />
+  </Provider>
+);
+
+test('should render', () => {
+  const { container } = render(setup(mockedProps));
+  expect(container).toBeInTheDocument();
+});
+
+test('should render the edit button', () => {
+  const editModeOffProps = {
+    ...mockedProps,
+    editMode: false,
+  };
+  render(setup(editModeOffProps));
+  const editButton = screen.getAllByRole('button')[0];

Review comment:
       Can you use `getByRole('button', { name: 'Edit' })`? If not, can you use `getByLabelText('Edit')`?

##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/Header.test.tsx
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import Header from './index';
+
+const mockedProps = {
+  toggleFiltersBar: jest.fn(),
+  onApply: jest.fn(),
+  setDataMaskSelected: jest.fn(),
+  dataMaskSelected: {
+    DefaultsID: {
+      currentState: {
+        value: null,
+      },
+    },
+  },
+  dataMaskApplied: {
+    DefaultsID: {
+      id: 'DefaultsID',
+      currentState: {
+        value: null,
+      },
+    },
+  },
+  isApplyDisabled: false,
+};
+
+test('should render', () => {
+  const { container } = render(<Header {...mockedProps} />, { useRedux: true });
+  expect(container).toBeInTheDocument();
+});
+
+test('should render the "Filters" heading', () => {
+  render(<Header {...mockedProps} />, { useRedux: true });
+  expect(screen.getByText('Filters')).toBeInTheDocument();
+});
+
+test('should render the "Clear all" option', () => {
+  render(<Header {...mockedProps} />, { useRedux: true });
+  expect(screen.getByText('Clear all')).toBeInTheDocument();
+});
+
+test('should render the "Apply" button', () => {
+  render(<Header {...mockedProps} />, { useRedux: true });
+  expect(screen.getByText('Apply')).toBeInTheDocument();
+  expect(screen.getByText('Apply').parentElement).toBeEnabled();
+});
+
+test('should render the "Clear all" button as disabled', () => {
+  render(<Header {...mockedProps} />, { useRedux: true });
+  const clearBtn = screen.getByText('Clear all');
+  expect(clearBtn.parentElement).toBeDisabled();
+});
+
+test('should render the "Apply" button as disabled', () => {
+  const applyDisabledProps = {
+    ...mockedProps,
+    isApplyDisabled: true,
+  };
+  render(<Header {...applyDisabledProps} />, { useRedux: true });
+  const applyBtn = screen.getByText('Apply');
+  expect(applyBtn.parentElement).toBeDisabled();
+  userEvent.click(applyBtn);
+  expect(mockedProps.onApply).not.toHaveBeenCalled();
+});
+
+test('should apply', () => {
+  render(<Header {...mockedProps} />, { useRedux: true });
+  const applyBtn = screen.getByText('Apply');
+  userEvent.click(applyBtn);

Review comment:
       ```suggestion
     expect(mockedProps.onApply).not.toHaveBeenCalled();
     userEvent.click(applyBtn);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (91d401e) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.02%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 91d401e differs from pull request most recent head c88e44e. Consider uploading reports for the commit c88e44e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   + Coverage   76.54%   77.56%   +1.02%     
   ==========================================
     Files         934      938       +4     
     Lines       47393    47580     +187     
     Branches     5964     6002      +38     
   ==========================================
   + Hits        36276    36907     +631     
   + Misses      10939    10517     -422     
   + Partials      178      156      -22     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.02% <ø> (+4.66%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `34.00% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `43.47% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `28.20% <ø> (-3.23%)` | :arrow_down: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `47.61% <ø> (ø)` | |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `4.54% <ø> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `80.95% <ø> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `91.80% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `59.74% <0.00%> (-16.24%)` | :arrow_down: |
   | ... and [101 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [1d8d067...c88e44e](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13916:
URL: https://github.com/apache/superset/pull/13916


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] pkdotson commented on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-814504884


   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (91d401e) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.70%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 91d401e differs from pull request most recent head f676e7b. Consider uploading reports for the commit f676e7b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   - Coverage   79.21%   78.50%   -0.71%     
   ==========================================
     Files         936      934       -2     
     Lines       47408    47350      -58     
     Branches     5940     5945       +5     
   ==========================================
   - Hits        37554    37172     -382     
   - Misses       9727    10034     +307     
   - Partials      127      144      +17     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <ø> (-0.02%)` | :arrow_down: |
   | javascript | `66.83% <100.00%> (-1.62%)` | :arrow_down: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `90.32% <100.00%> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `93.58% <100.00%> (ø)` | |
   | [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [100 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [f06d534...f676e7b](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (91d401e) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.96%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 91d401e differs from pull request most recent head c88e44e. Consider uploading reports for the commit c88e44e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   + Coverage   76.54%   78.50%   +1.96%     
   ==========================================
     Files         934      934              
     Lines       47393    47350      -43     
     Branches     5964     5945      -19     
   ==========================================
   + Hits        36276    37172     +896     
   + Misses      10939    10034     -905     
   + Partials      178      144      -34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <ø> (+7.67%)` | :arrow_up: |
   | javascript | `66.83% <100.00%> (+0.54%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `90.32% <100.00%> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `93.58% <100.00%> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `91.66% <0.00%> (-0.34%)` | :arrow_down: |
   | ... and [119 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [1d8d067...c88e44e](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (f676e7b) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.16%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   - Coverage   79.21%   79.04%   -0.17%     
   ==========================================
     Files         936      940       +4     
     Lines       47408    47593     +185     
     Branches     5940     5978      +38     
   ==========================================
   + Hits        37554    37621      +67     
   - Misses       9727     9845     +118     
     Partials      127      127              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.04% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `34.00% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `43.47% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `28.20% <ø> (-3.23%)` | :arrow_down: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `47.61% <ø> (ø)` | |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `4.54% <ø> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `80.95% <ø> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `91.80% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | [...ativeFilters/FilterBar/FilterConfigurationLink.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rLnRzeA==) | `62.50% <0.00%> (-37.50%)` | :arrow_down: |
   | ... and [7 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [f06d534...f676e7b](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812157887


   @junlincc @rusackas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] yardz commented on a change in pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13916:
URL: https://github.com/apache/superset/pull/13916#discussion_r608975918



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/Header.test.tsx
##########
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import Header from '.';
+
+const mockedProps = {

Review comment:
       Don't you think it would be interesting to apply a factory here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (f676e7b) into [master](https://codecov.io/gh/apache/superset/commit/2c96c5b3419de54c898c773bff00591e0c623fc2?el=desc) (2c96c5b) will **decrease** coverage by `0.25%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head f676e7b differs from pull request most recent head aa400ec. Consider uploading reports for the commit aa400ec to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   - Coverage   79.30%   79.04%   -0.26%     
   ==========================================
     Files         938      940       +2     
     Lines       47523    47593      +70     
     Branches     5940     5978      +38     
   ==========================================
   - Hits        37687    37621      -66     
   - Misses       9710     9845     +135     
   - Partials      126      127       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.04% <ø> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `34.00% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `43.47% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `28.20% <ø> (-3.23%)` | :arrow_down: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `47.61% <ø> (ø)` | |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `4.54% <ø> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `80.95% <ø> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `91.80% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (-76.93%)` | :arrow_down: |
   | ... and [47 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [9e03b6d...aa400ec](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] yardz commented on a change in pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13916:
URL: https://github.com/apache/superset/pull/13916#discussion_r608977467



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/EditSection.test.tsx
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import userEvent from '@testing-library/user-event';
+import { mockStore } from 'spec/fixtures/mockStore';
+import { Provider } from 'react-redux';
+import EditSection, { EditSectionProps }  from './EditSection';
+
+const mockedProps = {

Review comment:
       Same thing here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] yardz commented on a change in pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13916:
URL: https://github.com/apache/superset/pull/13916#discussion_r608979667



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.test.tsx
##########
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { render, screen } from 'spec/helpers/testing-library';
+import { mockStore } from 'spec/fixtures/mockStore';
+import { Provider } from 'react-redux';
+import FilterSets, { FilterSetsProps } from './FilterSets';
+
+const mockedProps = {
+  disabled: false,
+  isFilterSetChanged: false,
+  dataMaskSelected: {
+    'filter-id': {
+      currentState: {
+        value: [],
+      },
+    },
+  },
+  onEditFilterSet: jest.fn(),
+  onFilterSelectionChange: jest.fn(),
+};
+
+const setup = (props: FilterSetsProps) => (
+  <Provider store={mockStore}>
+    <FilterSets {...props} />
+  </Provider>
+);
+
+test('should render', () => {
+  const { container } = render(setup(mockedProps));
+  expect(container).toBeInTheDocument();
+  screen.debug();

Review comment:
       Forgot the debug here :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (c7bd361) into [master](https://codecov.io/gh/apache/superset/commit/2c96c5b3419de54c898c773bff00591e0c623fc2?el=desc) (2c96c5b) will **increase** coverage by `0.26%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head c7bd361 differs from pull request most recent head aa400ec. Consider uploading reports for the commit aa400ec to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   + Coverage   79.30%   79.57%   +0.26%     
   ==========================================
     Files         938      935       -3     
     Lines       47523    47432      -91     
     Branches     5940     5948       +8     
   ==========================================
   + Hits        37687    37742      +55     
   + Misses       9710     9569     -141     
   + Partials      126      121       -5     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.08% <ø> (+0.02%)` | :arrow_up: |
   | javascript | `69.63% <100.00%> (+0.77%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `92.00% <100.00%> (ø)` | |
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `90.32% <100.00%> (ø)` | |
   | ... and [43 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [9e03b6d...aa400ec](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (91d401e) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.55%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 91d401e differs from pull request most recent head c88e44e. Consider uploading reports for the commit c88e44e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   + Coverage   76.54%   78.09%   +1.55%     
   ==========================================
     Files         934      938       +4     
     Lines       47393    47580     +187     
     Branches     5964     6002      +38     
   ==========================================
   + Hits        36276    37158     +882     
   + Misses      10939    10278     -661     
   + Partials      178      144      -34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <ø> (+7.67%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `34.00% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `43.47% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `28.20% <ø> (-3.23%)` | :arrow_down: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `47.61% <ø> (ø)` | |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `4.54% <ø> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `80.95% <ø> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `91.80% <ø> (ø)` | |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `95.34% <100.00%> (ø)` | |
   | ... and [114 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [1d8d067...c88e44e](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13916: test: Tests audit for the Dashboard FilterBar

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13916:
URL: https://github.com/apache/superset/pull/13916#issuecomment-812580569


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=h1) Report
   > Merging [#13916](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=desc) (c7bd361) into [master](https://codecov.io/gh/apache/superset/commit/2c96c5b3419de54c898c773bff00591e0c623fc2?el=desc) (2c96c5b) will **decrease** coverage by `1.26%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head c7bd361 differs from pull request most recent head aa400ec. Consider uploading reports for the commit aa400ec to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13916/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13916      +/-   ##
   ==========================================
   - Coverage   79.30%   78.03%   -1.27%     
   ==========================================
     Files         938      946       +8     
     Lines       47523    47966     +443     
     Branches     5940     6092     +152     
   ==========================================
   - Hits        37687    37432     -255     
   - Misses       9710    10387     +677     
   - Partials      126      147      +21     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.11% <ø> (-3.95%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `41.02% <ø> (ø)` | |
   | [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
   | [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `34.00% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `43.47% <ø> (ø)` | |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `28.20% <ø> (-3.23%)` | :arrow_down: |
   | [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `47.61% <ø> (ø)` | |
   | [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `4.54% <ø> (ø)` | |
   | [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `80.95% <ø> (ø)` | |
   | [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `91.80% <ø> (ø)` | |
   | ... and [98 more](https://codecov.io/gh/apache/superset/pull/13916/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=footer). Last update [9e03b6d...aa400ec](https://codecov.io/gh/apache/superset/pull/13916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org