You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/30 06:55:08 UTC

[GitHub] [skywalking-goapi] mrproliu commented on a change in pull request #13: Import envoy metrics/als protocols

mrproliu commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-goapi/pull/13#discussion_r719110320



##########
File path: go.mod
##########
@@ -3,8 +3,8 @@ module skywalking.apache.org/repo/goapi
 go 1.16
 
 require (
-	golang.org/x/net v0.0.0-20190620200207-3b0461eec859 // indirect
-	golang.org/x/sys v0.0.0-20200116001909-b77594299b42 // indirect
+	github.com/envoyproxy/go-control-plane v0.9.9

Review comment:
       the `data-plane-api` just including the `proto` files, not include any generated `go` files, they just define in `data-plane-api`.
   The `go-control-plane` is the real generated proto go files place. 
   
   > We have nothing to do with go-cp for now, do we?
   
   We need to use `go-control-plane`, the satellite `SniffData`reference them generated `go` file, not `proto` file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org