You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/01 18:07:19 UTC
[GitHub] [camel-website] zregvart commented on a change in pull request #443: CAMEL-15360: fix HTML validation issues
zregvart commented on a change in pull request #443:
URL: https://github.com/apache/camel-website/pull/443#discussion_r463985824
##########
File path: layouts/partials/footer.html
##########
@@ -6,66 +6,50 @@
</div>
<footer>
<div class="footer">
+ <figure class="logo">
+ <img class="logo" src="/_/img/logo-d.svg" alt="Apache Camel Logo"
+ aria-label="white silhouette of a camel in front of a sand dune">
+ </figure>
+ <input id="footer-toggle-overview" type="checkbox" title="Show/Hide Overview section" />
<dl>
- <figure class="logo">
- <img class="logo" src="/_/img/logo-d.svg" alt="Apache Camel Logo"
- aria-label="white silhouette of a camel in front of a sand dune">
- </figure>
- <dt>Overview</dt>
- <input type="checkbox" id="show-overview"/>
- <label for="show-overview"><img class="show-menu" src="/_/img/show-footer-menu.svg"></label>
- <label for="show-overview"><img class="hide-menu" src="/_/img/hide-footer-menu.svg"></label>
- <div class="footer-menu">
- <dd><a href="/blog/">Blog</a></dd>
- <dd><a href="/docs/">Documentation</a></dd>
- <dd><a href="/community/support/">Community</a></dd>
- <dd><a href="/blog/">Download</a></dd>
- </div>
+ <dt><label for="footer-toggle-overview">Overview</label><label for="footer-toggle-overview">＋</label></dt>
Review comment:
Yeah I was preoccupied with mobile version that I forgot to check the desktop one. Not sure if assigning `id`s here would be the correct approach. Assigning same `id` to more than one element is not valid HTML. I've set the `display: none` via CSS selector: `footer .footer dl dt label:nth-child(2)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org