You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/19 00:48:36 UTC
[GitHub] [airflow] mik-laj opened a new pull request #10394: Group monitoring guides in one section
mik-laj opened a new pull request #10394:
URL: https://github.com/apache/airflow/pull/10394
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10394: Group monitoring guides in one section
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10394:
URL: https://github.com/apache/airflow/pull/10394#issuecomment-676244580
> In my opinion Logging & Monitoring should be separate sections.
>
> Or the sections title needs to change from "Monitoring" to "Logging & Monitoring"
Agree - splitting logging and monitoring seems like a good idea. Logging is something you can gather for future auditing etc. while monitoring is more about checking what's going on now. They have some overlap and you can use logs when your monitoring finds some anomalies or you can use logs to do monitoring, but for me, they are two different things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10394: Group logging&monitoring guides in one section
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10394:
URL: https://github.com/apache/airflow/pull/10394#issuecomment-676308421
I changed the title of the section. I didn't create a new section just for logging because we only have one article on this topic and it's very close to each other, though it's not the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10394: Group logging & monitoring guides in one section
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10394:
URL: https://github.com/apache/airflow/pull/10394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org