Re: Travis valgrind errors in SASL library.

[Andrew Stitcher <as...@redhat.com>]

[Added dev@qpid, as I think it's relevant to all proton devs]

On Thu, 2016-02-25 at 18:49 -0500, Alan Conway wrote:
> Have either of you looked at the travis valgrind errors in the SASL
> library? I've attached a sample.

I've not understood it yet, I have a strong suspicion it's due to the
crypto library in openssl.

It seems to be showing up in libsasl only because it is being passed in
a name that comes from uninitialised data somehow.

My guess is that the user name is partially uninitialised, as this
comes from the client certificate I bet that is caused by the openssl
library somehow.

The errors beneath sasl_server_new make no sense as we only pass in
a constant string and NULL so there isn't anything that could be
uninitialised as far as I can see.

Having said that the version of cyrus sasl being used seems very old -
2.0.25 as opposed to 2.1.26. So I'm not sure we should care all that
much.

I say we add suppressions for these issues as tightly as we can and
just wash our hands!

The travis failures are becoming a drag.

Any different opinions

Andrew


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

Re: Travis valgrind errors in SASL library.

[Alan Conway <ac...@redhat.com>]

On Fri, 2016-02-26 at 13:15 -0500, Andrew Stitcher wrote:
> 
> I say we add suppressions for these issues as tightly as we can and
> just wash our hands!
> 
> The travis failures are becoming a drag.

I see no way to write reasonable suppressions, the sasl and crypto libs
have no debug info so we'd have to supress everything under
sasl_server_new and sasl_server_step, which is effectively no valgrind
for server-side use of SASL.

Can we just turn valgrind off in travis.yml? That will give us useful
result from travis on compilability etc. and we can do un-supressed
valgrind checking on our own builds.

Cheers,
Alan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org