You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/29 05:49:29 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4100: Finish accurate assert for alter table
terrymanu opened a new pull request #4100: Finish accurate assert for alter table
URL: https://github.com/apache/incubator-shardingsphere/pull/4100
For #3947.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4100:
Finish accurate assert for alter table
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4100: Finish accurate assert for alter table
URL: https://github.com/apache/incubator-shardingsphere/pull/4100#issuecomment-579610670
Invalid because version control error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #4100:
Finish accurate assert for alter table
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #4100: Finish accurate assert for alter table
URL: https://github.com/apache/incubator-shardingsphere/pull/4100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4100:
Finish accurate assert for alter table
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4100: Finish accurate assert for alter table
URL: https://github.com/apache/incubator-shardingsphere/pull/4100#issuecomment-579612117
## Pull Request Test Coverage Report for [Build 1521](https://coveralls.io/builds/28395399)
* **10899** of **16402** **(66.45%)** changed or added relevant lines in **985** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-7.7%**) to **66.449%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/yaml/config/YamlEncryptColumnRuleConfiguration.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fyaml%2Fconfig%2FYamlEncryptColumnRuleConfiguration.java#L31) | 0 | 1 | 0.0%
| [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/impl/EncryptEqualCondition.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fcondition%2Fimpl%2FEncryptEqualCondition.java#L84) | 21 | 22 | 95.45%
| [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/parameter/impl/EncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fparameter%2Fimpl%2FEncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java#L58) | 22 | 23 | 95.65%
| [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L85) | 57 | 58 | 98.28%
| [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/pojo/EncryptPredicateInRightValueToken.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fpojo%2FEncryptPredicateInRightValueToken.java#L59) | 15 | 16 | 93.75%
| [master-slave-core/master-slave-core-route/src/main/java/org/apache/shardingsphere/masterslave/route/engine/impl/MasterVisitedManager.java](https://coveralls.io/builds/28395399/source?filename=master-slave-core%2Fmaster-slave-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmasterslave%2Froute%2Fengine%2Fimpl%2FMasterVisitedManager.java#L27) | 7 | 8 | 87.5%
| [sharding-core/database-time-service/src/main/java/org/apache/shardingsphere/route/time/TimeServiceConfiguration.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fdatabase-time-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Froute%2Ftime%2FTimeServiceConfiguration.java#L68) | 20 | 21 | 95.24%
| [sharding-core/database-time-service/src/main/java/org/apache/shardingsphere/route/time/exception/NoDatabaseSQLEntrySupportException.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fdatabase-time-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Froute%2Ftime%2Fexception%2FNoDatabaseSQLEntrySupportException.java#L25) | 0 | 1 | 0.0%
| [sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/TableRuleConfiguration.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fsharding-core-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fapi%2Fconfig%2Fsharding%2FTableRuleConfiguration.java#L48) | 6 | 7 | 85.71%
| [sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/strategy/NoneShardingStrategyConfiguration.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fsharding-core-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fapi%2Fconfig%2Fsharding%2Fstrategy%2FNoneShardingStrategyConfiguration.java#L25) | 0 | 1 | 0.0%
<!-- | **Total:** | **10899** | **16402** | **66.45%** | -->
| Totals | [](https://coveralls.io/builds/28395399) |
| :-- | --: |
| Change from base [Build 6250](https://coveralls.io/builds/20888424): | -7.7% |
| Covered Lines: | 10899 |
| Relevant Lines: | 16402 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services