You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/20 09:26:58 UTC

[GitHub] [rocketmq] 2259289435 opened a new pull request #1874: Support StartDeliverTime

2259289435 opened a new pull request #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874
 
 
   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29595901/badge)](https://coveralls.io/builds/29595901)
   
   Coverage increased (+0.06%) to 50.888% when pulling **3e7c86680ee99ffa06bb59584859d30a63c05aea on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls commented on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29498751/badge)](https://coveralls.io/builds/29498751)
   
   Coverage increased (+0.08%) to 50.904% when pulling **385fc8e52e564b3a2711f808af311139f792c274 on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] 2259289435 commented on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
2259289435 commented on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-602311653
 
 
   With the possibility of early delivery, the error is at the lowest level, and the default is 1 second.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29518024/badge)](https://coveralls.io/builds/29518024)
   
   Coverage increased (+0.1%) to 50.945% when pulling **c5410c5a4c72729857bcdca6b54b967fdcb0b227 on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29520412/badge)](https://coveralls.io/builds/29520412)
   
   Coverage increased (+0.07%) to 50.896% when pulling **67af5904646c7130ca0fec38e3203fb56f06c89c on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29516133/badge)](https://coveralls.io/builds/29516133)
   
   Coverage decreased (-0.03%) to 50.8% when pulling **44a3ca7e05ac73bcda075c826bb73ff859d13f12 on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29595058/badge)](https://coveralls.io/builds/29595058)
   
   Coverage decreased (-0.01%) to 50.813% when pulling **521e6b63bd4790809592431695911390fcbbe1c2 on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] 2259289435 commented on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
2259289435 commented on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-603812430
 
 
   Welcome to the discussion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29515947/badge)](https://coveralls.io/builds/29515947)
   
   Coverage increased (+0.1%) to 50.952% when pulling **d1dce3e8708655b96442fba453af686f9a439e68 on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] 2259289435 commented on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
2259289435 commented on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-603568051
 
 
   #1882 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1874: Support StartDeliverTime

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1874: Support StartDeliverTime
URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-601666798
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29516060/badge)](https://coveralls.io/builds/29516060)
   
   Coverage decreased (-0.06%) to 50.769% when pulling **1c10572e9c99b8344afbd226cc058f7e3714188f on 2259289435:StartDeliverTime** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services