You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/21 17:53:00 UTC
[jira] [Commented] (SAMZA-1427) KafkaCheckpointMgr should use
KafkaSystemFactory to instantiate systemConsumer and systemProducer
[ https://issues.apache.org/jira/browse/SAMZA-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175193#comment-16175193 ]
ASF GitHub Bot commented on SAMZA-1427:
---------------------------------------
GitHub user sborya opened a pull request:
https://github.com/apache/samza/pull/299
SAMZA-1427: use systemFactory in checkpoint manager.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sborya/samza LiKafkaClient
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit e633eba599595a33c71f47928c35a16909f9c662
Author: Boris Shkolnik <bo...@apache.org>
Date: 2017-09-18T20:40:08Z
use factory for checkpoint manager
commit 0b0d031dd6ba690491fdf4e5189af5b577e6b4c0
Author: Boris Shkolnik <bo...@apache.org>
Date: 2017-09-18T22:41:18Z
Merge branch 'master' into LiKafkaClient
commit 784a0ee1bc19da45d2aec9f3e07be7712ac2dfb5
Author: Boris Shkolnik <bs...@linkedin.com>
Date: 2017-09-20T18:10:49Z
use abstract instead of interface for scala 2.10
commit be3cde86fe94b5c31a38e9181bda9ce3b49d5c52
Author: Boris Shkolnik <bs...@linkedin.com>
Date: 2017-09-20T18:12:05Z
Merge branch 'master' into LiKafkaClient
commit 680c7aeefc26dda605d668113670dd32947966e8
Author: Boris Shkolnik <bs...@linkedin.com>
Date: 2017-09-21T17:10:36Z
Merge branch 'master' into LiKafkaClient
commit 63eb5a521b9e69434a097e67af603e0addc5eacc
Author: Boris Shkolnik <bs...@linkedin.com>
Date: 2017-09-21T17:39:19Z
cleanup
----
> KafkaCheckpointMgr should use KafkaSystemFactory to instantiate systemConsumer and systemProducer
> -------------------------------------------------------------------------------------------------
>
> Key: SAMZA-1427
> URL: https://issues.apache.org/jira/browse/SAMZA-1427
> Project: Samza
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> Currently KafkaCheckpointMgr is using SimpleKafkaConsumer directly to read the the checkpoint stream. Instead it should use a factory, so another factory can be plugged in if needed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)