You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by NickManley <gi...@git.apache.org> on 2016/05/21 20:14:20 UTC
[GitHub] commons-lang pull request: LANG-1236: Add StopWatch#getTime with S...
GitHub user NickManley opened a pull request:
https://github.com/apache/commons-lang/pull/153
LANG-1236: Add StopWatch#getTime with String Format Argument
I wasn't sure if this kind of thing should be a part of the getTime method or if toString should be overloaded to take a format argument. Either way seems okay to me. I put it on getTime, but if there are disagreements about that, I would be okay with putting it in toString instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NickManley/commons-lang formatted_getTime
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit 9f6797d93172b1d79298e5ca63e995f2242f3f04
Author: Nick Manley <ni...@outlook.com>
Date: 2016-05-21T18:53:49Z
LANG-1223: Add StopWatch#getTime(TimeUnit)
commit 82a58a0b11c3086781bd526dc596e33889bd3f3a
Author: Nick Manley <ni...@outlook.com>
Date: 2016-05-21T20:06:06Z
Add String formatting to StopWatch#getTime
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #153: LANG-1236: Add StopWatch#getTime with String Format...
Posted by NickManley <gi...@git.apache.org>.
Github user NickManley commented on the issue:
https://github.com/apache/commons-lang/pull/153
Closing the pull request. Ticket marked as Won't Fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #153: LANG-1236: Add StopWatch#getTime with String...
Posted by NickManley <gi...@git.apache.org>.
Github user NickManley closed the pull request at:
https://github.com/apache/commons-lang/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---