You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2018/11/26 08:15:02 UTC

[GitHub] win80540 commented on a change in pull request #1816: [WEEX-669][android] fix slider crash when adapter is null

win80540 commented on a change in pull request #1816: [WEEX-669][android] fix slider crash when adapter is null
URL: https://github.com/apache/incubator-weex/pull/1816#discussion_r236153772
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
 ##########
 @@ -214,7 +214,14 @@ public void run() {
 
   @Override
   public void setLayout(WXComponent component) {
-    mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+    if (TextUtils.isEmpty(component.getComponentType())
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services